Fix minimap show/hide #1103
Merged
Fix minimap show/hide #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a menu item to hide the minimap. It was only toggling the minimap without changing the layout of the panel at the bottom right, resulting in an almost-empty widget still hiding as much of the map as before. Now, hiding the minimap properly reduces the size of the bottom right widget, at the expense of also hiding the zoom buttons located there. The manual layout (i.e. without using QLayout) causes some trouble when widgets are hidden or restored. Eventually I chose to post a LayoutRequest event by hand to the widget doing the layout. If one day we write a proper QLayout for the overlay widgets, we can remove this. Closes longturn#1096.
When the minimap is hidden then shown, the three tool buttons on its right have a negative height for one frame. This causes QPainter to be unhappy and complain loudly. Silence most of the warnings by not attempting to render SVG icons with negative sizes.
psampathkumar
requested changes
Jul 9, 2022
lmoureaux
added a commit
to lmoureaux/freeciv21
that referenced
this pull request
Jul 9, 2022
Fixed. Yes, I used a |
lmoureaux
added a commit
to lmoureaux/freeciv21
that referenced
this pull request
Jul 9, 2022
lmoureaux
force-pushed
the
bugfix/minimap-show-hide
branch
from
f8d63b3 to
9e08fec
Compare
lmoureaux
force-pushed
the
bugfix/minimap-show-hide
branch
from
9e08fec to
c82a421
Compare
|
Hmm! MacOS build failed!didn't expect that! 😄 |
psampathkumar
approved these changes
Jul 11, 2022
Launched a new attempt |
|
Mac build works now. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1096.
I chose not to remove the option (for now), instead implementing a more or less sensible behavior.