Behaviour of "hide minimap" is broken #1096
Comments
psampathkumar
added
bug
|
I would be in favor of removing the option altogether. |
|
I'm ambivalent about this. It is indeed convenient to have the option, but tbh, I dont use it at all in normal usage. |
lmoureaux
added a commit
to lmoureaux/freeciv21
that referenced
this issue
Jul 9, 2022
lmoureaux
added a commit
to lmoureaux/freeciv21
that referenced
this issue
Jul 9, 2022
There is a menu item to hide the minimap. It was only toggling the minimap without changing the layout of the panel at the bottom right, resulting in an almost-empty widget still hiding as much of the map as before. Now, hiding the minimap properly reduces the size of the bottom right widget, at the expense of also hiding the zoom buttons located there. The manual layout (i.e. without using QLayout) causes some trouble when widgets are hidden or restored. Eventually I chose to post a LayoutRequest event by hand to the widget doing the layout. If one day we write a proper QLayout for the overlay widgets, we can remove this. Closes longturn#1096.
Merged
psampathkumar
pushed a commit
that referenced
this issue
Jul 11, 2022
psampathkumar
pushed a commit
that referenced
this issue
Jul 11, 2022
There is a menu item to hide the minimap. It was only toggling the minimap without changing the layout of the panel at the bottom right, resulting in an almost-empty widget still hiding as much of the map as before. Now, hiding the minimap properly reduces the size of the bottom right widget, at the expense of also hiding the zoom buttons located there. The manual layout (i.e. without using QLayout) causes some trouble when widgets are hidden or restored. Eventually I chose to post a LayoutRequest event by hand to the widget doing the layout. If one day we write a proper QLayout for the overlay widgets, we can remove this. Closes #1096.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Using the hide minimap option from the menu or "ctrl+M" must just hide the minimap, but it causes unintended behaviour
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Just the minimap disappears along with the empty space, and the zoom buttons stay above the turn done button. It shouldnt affect the behaviour of widgets
Screenshots
Notice that the move handle in the corner of widgets have disappeared.
Platform and version (please complete the following information):
The text was updated successfully, but these errors were encountered: