Bugfix/remove unused functions3 #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psampathkumar
force-pushed
the
bugfix/remove-unused-functions3
branch
from
9956da1 to
351efb1
Compare
psampathkumar
force-pushed
the
bugfix/remove-unused-functions3
branch
from
351efb1 to
62271c5
Compare
lmoureaux
reviewed
Jul 5, 2022
| @@ -12,4 +12,5 @@ | |||
|
|
|||
| struct connection; | |||
|
|
|||
| // This function is called from the generated code in generate_packets.py | |||
There was a problem hiding this comment.
Yeah it's obvious since it starts with handle_ :P
psampathkumar
force-pushed
the
bugfix/remove-unused-functions3
branch
from
341bb17 to
362bac5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll rebase after merging #1072