Draft: Bugfix/remove unused functions2 #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psampathkumar
force-pushed
the
bugfix/remove-unused-functions2
branch
from
4fc9dae to
47590c9
Compare
lmoureaux
reviewed
Jun 29, 2022
dependencies/cvercmp/cvercmp.c
Outdated
Comment on lines
2
to
9
| * * | ||
| * (c) 2011-2015 Marko Lindqvist * | ||
| * * | ||
| * Version contributed to Freeciv has been made available * | ||
| * under GNU Public License; either version 2, or * | ||
| * (at your option) any later version. * | ||
| * * | ||
| *********************************************************/ |
There was a problem hiding this comment.
Why the reformatting? This file doesn't follow the style convention since it's in dependencies (we should move it to utility at some point, but that's another matter).
If you want to reformat it, let's go wild and change this to SPDX
dependencies/cvercmp/cvercmp.h
Outdated
Comment on lines
2
to
9
| * * | ||
| * (c) 2011-2015 Marko Lindqvist * | ||
| * * | ||
| * Version contributed to Freeciv has been made available * | ||
| * under GNU Public License; either version 2, or * | ||
| * (at your option) any later version. * | ||
| * * | ||
| *********************************************************/ |
There was a problem hiding this comment.
Same question about reformatting
psampathkumar
force-pushed
the
bugfix/remove-unused-functions2
branch
from
47590c9 to
1b9e561
Compare
|
I assume this is no longer a draft? (sorry for the delay...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll rebase after #1067 is merged.