Refactoring code and fixes: cmake, crashes and codecy

[NIKEA-SOFT]

No description provided.

[lmoureaux]

Very easy to review! It's clear that the second commit changes nothing, which let me focus on the rest of the code. I have two minor comments on the last commit, I leave them to you (i.e. do as you prefer).

Apparently we see in #999 that adding the header files to CMakeLists isn't necessary for VS 2022. I think we can still merge this PR while we figure out whether this is indeed the case, since the change could be reverted without breaking the blame too much (I would prefer to have only the .cpp if possible, since that's how CMake is intended to work and it's less verbose).

[jwrober]

When I run a build of this PR I am seeing a lot more warnings that from what we see on master branch right now.

common/packets_gen.cpp:8284:48: warning: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct packet_city_info’ with no trivial copy-assignment; use assignment or value-initialization instead [-Wclass-memaccess]
common/packets_gen.cpp:8766:32: warning: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct packet_city_info’ with no trivial copy-assignment; use assignment or value-initialization instead [-Wclass-memaccess]
common/packets_gen.cpp:12111:48: warning: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct packet_city_manager’ with no trivial copy-assignment; use assignment or value-initialization instead [-Wclass-memaccess]
common/packets_gen.cpp:12161:32: warning: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct packet_city_manager’ with no trivial copy-assignment; use assignment or value-initialization instead [-Wclass-memaccess]
../client/governor.cpp:439:46: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct cm_parameter’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
../server/citytools.cpp:2609:66: warning: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct cm_parameter’ with no trivial copy-assignment; use assignment or value-initialization instead [-Wclass-memaccess]
../client/packhand.cpp:170:66: warning: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct player’ with no trivial copy-assignment; use assignment or value-initialization instead [-Wclass-memaccess]

Not sure if this is an issue or not, just making mention of it.

[NIKEA-SOFT]

When I run a build of this PR I am seeing a lot more warnings that from what we see on master branch right now.

common/packets_gen.cpp:8284:48: warning: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct packet_city_info’ with no trivial copy-assignment; use assignment or value-initialization instead [-Wclass-memaccess]
common/packets_gen.cpp:8766:32: warning: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct packet_city_info’ with no trivial copy-assignment; use assignment or value-initialization instead [-Wclass-memaccess]
common/packets_gen.cpp:12111:48: warning: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct packet_city_manager’ with no trivial copy-assignment; use assignment or value-initialization instead [-Wclass-memaccess]
common/packets_gen.cpp:12161:32: warning: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct packet_city_manager’ with no trivial copy-assignment; use assignment or value-initialization instead [-Wclass-memaccess]
../client/governor.cpp:439:46: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct cm_parameter’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
../server/citytools.cpp:2609:66: warning: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct cm_parameter’ with no trivial copy-assignment; use assignment or value-initialization instead [-Wclass-memaccess]
../client/packhand.cpp:170:66: warning: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct player’ with no trivial copy-assignment; use assignment or value-initialization instead [-Wclass-memaccess]

Not sure if this is an issue or not, just making mention of it.

Thank you for writing about this.
The problem is that the copy assignment operator defined by me changed the structure and it ceased to be a POD.
Fixed.