Don't include headers in CMakeLists.txt after all #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The headers were added because Microsoft Visual Studio's "Solution" view doesn't show the headers. However, VS' built-in CMake handling doesn't use the solution view and is based on folders (much like CMake itself). There is no recommendation from the CMake side on how to handle this problem with CMake's built-in generators for Visual Studio. Following the VS documentation and the instructions added in longturn#999, one can get (at least) decent VS support with IntelliSense working. This doesn't require keeping the headers in the CMakeLists, so remove them for more idiomatic CMake code. This reverts part of commit 6e38a15. See longturn#1005.
jwrober
approved these changes
May 10, 2022
lmoureaux
added a commit
to lmoureaux/freeciv21
that referenced
this pull request
Aug 22, 2022
When cancelling a network connection then going back to PAGE_NETWORK, the old connection was still around and any attempt to connect would fail with "Connection in progress". Cancel the connection when switching back to PAGE_MAIN so we can create a new one when we go back to PAGE_NETWORK. Might be related to longturn#785 or longturn#1008.
jwrober
pushed a commit
that referenced
this pull request
Aug 23, 2022
When cancelling a network connection then going back to PAGE_NETWORK, the old connection was still around and any attempt to connect would fail with "Connection in progress". Cancel the connection when switching back to PAGE_MAIN so we can create a new one when we go back to PAGE_NETWORK. Might be related to #785 or #1008.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The headers were added because Microsoft Visual Studio's "Solution" view
doesn't show the headers. However, VS' built-in CMake handling doesn't use the
solution view and is based on folders (much like CMake itself). There is no
recommendation from the CMake side on how to handle this problem with CMake's
built-in generators for Visual Studio.
Following the VS documentation and the instructions added in #999, one can get
(at least) decent VS support with IntelliSense working. This doesn't require
keeping the headers in the CMakeLists, so remove them for more idiomatic CMake
code.
This reverts part of commit 6e38a15.
See #1005.