Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit bouncing (eg breaking alliance) kills fueled units #931

Closed
lmoureaux opened this issue Mar 3, 2022 · 0 comments · Fixed by #932
Closed

Unit bouncing (eg breaking alliance) kills fueled units #931

lmoureaux opened this issue Mar 3, 2022 · 0 comments · Fixed by #932
Assignees
@psampathkumar
Labels
bug Something isn't working server This issue requires changes to the server

Comments

@lmoureaux
Copy link
Contributor

Describe the bug

In 2.6 and likely fc21, the unit bouncing code always kills fueled units because can_unit_survive_at_tile always returns false.

To Reproduce
Steps to reproduce the behavior:

  1. Put fueled units in an allied city
  2. Break alliance
  3. See your units being disbanded

Expected behavior
Units are bounced normally.

Platform and version (please complete the following information):

  • OS: irrelevant
  • Freeciv (!) version: 2.6 + longturn patches
  • Ruleset/Longturn game (if applicable): SG3
@lmoureaux lmoureaux added bug Something isn't working server This issue requires changes to the server labels Mar 3, 2022
psampathkumar added a commit to psampathkumar/freeciv21 that referenced this issue Mar 3, 2022
@psampathkumar
Bounce units to tiles where it can just exist if it cant "survive" in…
38cf46c 
… any of the available tiles.

Fixes longturn#931
@psampathkumar psampathkumar mentioned this issue Mar 3, 2022
Merged
lmoureaux pushed a commit that referenced this issue Apr 11, 2022
@psampathkumar @lmoureaux
Bounce units to tiles where it can just exist if it cant "survive" in…
4d392db 
… any of the available tiles.

Fixes #931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psampathkumar psampathkumar

Labels
bug Something isn't working server This issue requires changes to the server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bounce units to tiles where it can just exist if it cant "survive" in… psampathkumar/freeciv21
2 participants
@lmoureaux @psampathkumar