-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add alteration scripts compatibility test jobs #4627
Merged
simeng-li
merged 5 commits into
master
from
simeng-log-7144-ci-add-integration-for-staging-period
Oct 23, 2023
Merged
ci: add alteration scripts compatibility test jobs #4627
simeng-li
merged 5 commits into
master
from
simeng-log-7144-ci-add-integration-for-staging-period
Oct 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LOG-7144 CI: Add integration for staging period
目前 staging 时的测试还未被覆盖。 |
COMPARE TO
|
Name | Diff |
---|---|
.github/workflows/alteration-compatibility-integration-test.yml | 📉 -2.21 KB |
.github/workflows/integration-test.yml | 📉 -2.26 KB |
simeng-li
force-pushed
the
simeng-log-7144-ci-add-integration-for-staging-period
branch
from
October 9, 2023 10:13
e39295b
to
505f56d
Compare
simeng-li
requested review from
xiaoyijun,
charIeszhao,
a team and
wangsijie
and removed request for
a team
October 9, 2023 10:19
wangsijie
approved these changes
Oct 10, 2023
gao-sun
reviewed
Oct 10, 2023
gao-sun
reviewed
Oct 10, 2023
gao-sun
reviewed
Oct 10, 2023
darcyYe
approved these changes
Oct 12, 2023
- refactor the integration-test ci job using custom action - add db alteration integration-tests
simeng-li
force-pushed
the
simeng-log-7144-ci-add-integration-for-staging-period
branch
from
October 16, 2023 08:04
9f7b66f
to
0909bc4
Compare
fix the detection git diff
simeng-li
force-pushed
the
simeng-log-7144-ci-add-integration-for-staging-period
branch
from
October 16, 2023 08:22
92b4a44
to
d45d9c7
Compare
should not throw error if grep statement return empty
update the action reference
update the integration test action ref
xiaoyijun
approved these changes
Oct 18, 2023
simeng-li
deleted the
simeng-log-7144-ci-add-integration-for-staging-period
branch
October 23, 2023 03:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To address the issue of production errors caused by incompatible database alterations, we're introducing a new CI job dedicated to ensuring the compatibility of alteration scripts with our production code. This job aims to prevent altered data from breaking our production systems when the production DB has been altered but the new release code is launched to staging only.
This PR refactors the integration test, all the shared integration steps are extracted to the latest created custom GitHub actions:
PLEASE review the above actions as well.
Testing
Happy test
test based on the PR #4616.
Failing test
Simulate the PR #4582
Checklist
.changeset
OR