-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(schemas,core,cli): alter signing key type to json object #4582
refactor(schemas,core,cli): alter signing key type to json object #4582
Conversation
LOG-7146 Alter oidc private key type to support additional properties
Existing oidc private keys are Provide DB alter script to migrate existing config data |
COMPARE TO
|
Name | Diff |
---|---|
.changeset/lucky-brooms-hide.md | 📈 +217 Bytes |
packages/cli/src/commands/database/seed/oidc-config.ts | 📈 +302 Bytes |
packages/cli/src/commands/database/utils.ts | 📈 +328 Bytes |
packages/core/src/env-set/oidc.ts | 📈 +34 Bytes |
packages/core/src/middleware/koa-auth/utils.ts | 📈 +8 Bytes |
packages/schemas/alterations/next-1695647183-update-private-key-type.ts | 📈 +3.16 KB |
packages/schemas/src/types/logto-config.ts | 📈 +197 Bytes |
0559a9c
to
21e61f8
Compare
747369a
to
a0dae10
Compare
Since we don't have a design for this. What is the use case for the keyId and createdAt attributes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
04a1891
to
4be62e3
Compare
4be62e3
to
5e4820f
Compare
Summary
Alter Logto signing key type, convert it from
string
toJSON Object
, in order to provide additional information in Console, such as key ID and creation time.Testing
Alteration script works fine, both upgrade and downgrade.
Checklist
.changeset
OR
- [ ] This PR is not applicable for the checklist