Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: HTTPD access log parse failure on missing response #282

Merged
merged 7 commits into from
Aug 11, 2020
Merged

Fix: HTTPD access log parse failure on missing response #282

merged 7 commits into from
Aug 11, 2020

Conversation

kares
Copy link
Contributor

@kares kares commented Aug 10, 2020 •
edited
Loading

Without this fix the following line would not match the HTTPD_COMBINEDLOG pattern:
83.149.9.216 - a.user [11/Jan/2020:23:05:27 +0100] "OPTIONS /remote.php/ HTTP/1.1" - 7908 "-" "x-client"
due "-" response (after 7908 "-") not parsing as a number

NOTE: there's also some more specs (which aren't relevant to the change)

@kares kares marked this pull request as ready for review August 10, 2020 10:19
@kares kares mentioned this pull request Aug 10, 2020
Closed
@kares kares requested a review from yaauie August 10, 2020 10:29
colinsurprenant
colinsurprenant approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@colinsurprenant colinsurprenant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaauie yaauie self-assigned this Aug 10, 2020
yaauie
yaauie approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@yaauie yaauie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kares kares merged commit eaf9810 into logstash-plugins:master Aug 11, 2020
kares added a commit that referenced this pull request Aug 11, 2020
@kares
Fix: HTTPD access log parse failure on missing response (#282)
4947f3c
@kares kares mentioned this pull request Oct 14, 2020
Merged
kares added a commit that referenced this pull request Dec 16, 2020
@kares
Merge branch 'master' into ecs-wip
852944e 
* master:
  Fix: UNIXPATH to avoid DoS on long paths with unmatching chars (#292)
  Fix: HTTPD access log parse failure on missing response (#282)
@kares kares mentioned this pull request Jan 4, 2021
Closed
kares added a commit to kares/logstash-patterns-core that referenced this pull request Feb 17, 2021
@kares
Fix: HTTPD access log parse failure on missing response (logstash-plu…
e755600 
…gins#282)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaauie yaauie yaauie approved these changes

@colinsurprenant colinsurprenant colinsurprenant approved these changes

Assignees

@yaauie yaauie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kares @colinsurprenant @yaauie @elasticsearch-bot