Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate patterns JAVACLASS and JAVAFILE #237

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Remove duplicate patterns JAVACLASS and JAVAFILE #237

merged 1 commit into from
Nov 19, 2018

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Nov 19, 2018

No description provided.

@elasticsearch-bot elasticsearch-bot self-assigned this Nov 19, 2018
@jsvd
Copy link
Member Author

jsvd commented Nov 19, 2018

/cc @jakelandis as this duplication also exists in https://github.com/elastic/elasticsearch/blob/6.5/libs/grok/src/main/resources/patterns/java

robbavey
robbavey approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@robbavey robbavey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but seeing as the duplicate entries had different definitions, maybe some comment in the commit/changelog as to the reasons why those definitions were removed, and the effect of the removal.

@jsvd
Copy link
Member Author

jsvd commented Nov 19, 2018

maybe some comment in the commit/changelog as to the reasons why those definitions were removed

@robbavey that was my goal with the tests, both test an example of the pattern that only works for the remaining one.

@robbavey
Copy link
Contributor

@jsvd Ah cool, ok LGTM then

@jsvd jsvd merged commit 0204239 into logstash-plugins:master Nov 19, 2018
@jakelandis jakelandis mentioned this pull request Nov 19, 2018
Closed
@jakelandis
Copy link
Contributor

@jsvd - thanks for the heads up, issue logged for the ingest node: elastic/elasticsearch#35699

jakelandis pushed a commit to elastic/elasticsearch that referenced this pull request Nov 26, 2018
@pendext @jakelandis
ingest: grok remove duplicated patterns (#35886)
0baffda 
This commit removes the redundant (and incorrect) JAVACLASS
and JAVAFILE grok patterns. This helps to keep parity with 
Logstash's patterns. 

See also: logstash-plugins/logstash-patterns-core#237
 
closes #35699
jakelandis pushed a commit to elastic/elasticsearch that referenced this pull request Nov 26, 2018
@pendext @jakelandis
ingest: grok remove duplicated patterns (#35886)
4f17f1e 
This commit removes the redundant (and incorrect) JAVACLASS
and JAVAFILE grok patterns. This helps to keep parity with 
Logstash's patterns. 

See also: logstash-plugins/logstash-patterns-core#237
 
closes #35699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbavey robbavey robbavey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsvd @robbavey @jakelandis @elasticsearch-bot