Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingest: Grok: duplicate patterns JAVACLASS and JAVAFILE #35699

Closed
jakelandis opened this issue Nov 19, 2018 · 3 comments
Closed

Ingest: Grok: duplicate patterns JAVACLASS and JAVAFILE #35699

jakelandis opened this issue Nov 19, 2018 · 3 comments
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP good first issue low hanging fruit

Comments

@jakelandis
Copy link
Contributor

As discovered via Logstash : logstash-plugins/logstash-patterns-core#237

It appears that the Ingest Grok processor also has duplicated JAVACLASS and JAVAFILE definitions

https://github.com/elastic/elasticsearch/blob/6.5/libs/grok/src/main/resources/patterns/java

We should keep the top ones

JAVACLASS (?:[a-zA-Z$_][a-zA-Z$_0-9]*\.)*[a-zA-Z$_][a-zA-Z$_0-9]*
JAVAFILE (?:[A-Za-z0-9_. -]+)

and remove the lower ones.
@jakelandis jakelandis added good first issue low hanging fruit :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP labels Nov 19, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@jakelandis jakelandis mentioned this issue Nov 19, 2018
Merged
@ekalgolas
Copy link
Contributor

Can I work on this?

@pendext
Copy link
Contributor

pendext commented Nov 25, 2018

I didn't see any movement on this since @ekalgolas commented a week ago, so I opened a PR, #35886

jakelandis pushed a commit that referenced this issue Nov 26, 2018
@pendext @jakelandis
ingest: grok remove duplicated patterns (#35886)
4f17f1e 
This commit removes the redundant (and incorrect) JAVACLASS
and JAVAFILE grok patterns. This helps to keep parity with 
Logstash's patterns. 

See also: logstash-plugins/logstash-patterns-core#237
 
closes #35699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP good first issue low hanging fruit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jakelandis @pendext @ekalgolas @elasticmachine