Feat: Added retry_count and retry_delay config #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kares
commented
Feb 5, 2020
lib/logstash/outputs/s3/uploader.rb
Outdated
| retry | ||
| if tries < @retry_count | ||
| tries += 1 | ||
| logger.warn("Uploading failed, retrying (#{tries}).", :exception => e.class, :message => e.message, :path => file.path, :backtrace => e.backtrace) |
There was a problem hiding this comment.
as retry logging seems to "annoy" users I decreased logger.level to warn
(and added a new error message when retrying is done)
but users not configuring retry_count will only see logging downgraded to warn level.
if that is a potential problem and we should keep error level here, I am fine to do that ...
jsvd
approved these changes
Feb 7, 2020
Co-Authored-By: João Duarte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initially wanted to filter out specific errors that make sense to get retried (e.g. only rescue-ing
Aws::S3::Errors::ServiceErrorand inspectingerror.code) but possibilities are wild.resolves #216 (also closes #169)