Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow opting out from infinite upload retries #216

Closed
kares opened this issue Jan 21, 2020 · 0 comments · Fixed by #218
Closed

allow opting out from infinite upload retries #216

kares opened this issue Jan 21, 2020 · 0 comments · Fixed by #218

Comments

@kares
Copy link
Contributor

kares commented Jan 21, 2020

in some cases user might not want to keep on retry-ing upload forever.
the logic makes sense for "transient" errors (e.g. network/service failure) but is potentially problematic (generating a lot of noise at minimum) for arbitrary raises.

we potentially need to investigate the class of exceptions coming from s3 library.

this feature has been requested previously e.g. #169 and #160 ... the later case is specific to Errno::ENOENT which is now handled as a non-retry case #144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant