Fix leak of file handles that prevents gzip files from being cleaned up #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaauie
force-pushed
the
fix-leak-of-file-handles
branch
from
f1b0a62 to
a6d7fe2
Compare
Use `Zlib::GzipWriter::new(IO)` instead of `Zlib::GzipWriter::open(Object)`, since the latter effectively creates an additional file handle when passed an `IO`. This ensures that when we send `Zlib::GzipWriter#close`, the original `IO` is closed in turn. Resolves: logstash-plugins#190
yaauie
force-pushed
the
fix-leak-of-file-handles
branch
from
a6d7fe2 to
9043a39
Compare
|
bumped version and added changelog note, will merge/publish once the build goes green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Zlib::GzipWriter::new(IO)instead ofZlib::GzipWriter::open(Object), sincethe latter effectively creates an additional file handle when passed an
IO. Thisensures that when we send
Zlib::GzipWriter#close, the originalIOis closed inturn.
Resolves: #190