Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes for 5.6.13 #10077

Closed
wants to merge 2 commits into from
Closed

Conversation

robbavey
Copy link
Member

No description provided.

@robbavey robbavey requested a review from karenzone October 26, 2018 19:48
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds locally without error. Left a few comments for your consideration.

*S3 Output*

* Fixed leak of file handles that prevented temporary files from being cleaned up before pipeline restart https://github.com/logstash-plugins/logstash-output-s3/issues/190[#190]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we link to the fix instead of (or in addition to) the issue? logstash-plugins/logstash-output-s3#193

=== Logstash 5.6.13 Release Notes

* Make cgroups support more robust and provide the override similar to ES ({lsissue}/10012[#10010]).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to Made to be consistent with past tense in other items?

Copy link
Contributor

@danhermann danhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticsearch-bot
Copy link

Rob Bavey merged this into the following branches!

Branch Commits
5.6 6a8703d, c5dedba

elasticsearch-bot pushed a commit that referenced this pull request Nov 6, 2018
elasticsearch-bot pushed a commit that referenced this pull request Nov 6, 2018
@robbavey robbavey closed this Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants