Feat: improve SSL error logging/unwrapping #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbavey
approved these changes
Jun 15, 2021
| } catch (CertificateException ex) { | ||
| Throwable cause = ex.getCause(); | ||
| if (cause != null && "Empty input".equals(cause.getMessage())) { | ||
| continue; |
There was a problem hiding this comment.
Is there a case for debug or trace logging upon receiving this error, or is it always benign?
There was a problem hiding this comment.
good call, I simply converted from the .rb parts and did not revisit with potential logging.
the whole logic seems a bit unusual - would rather just use generateCertificates to read multiple entries.
anyhow, let's keep that as before and I am going to add a debug line around the caught "empty" exception.
There was a problem hiding this comment.
added debug logging + an extra check when expecting to read at least one certificate from ssl_cert
also worth noting (in the changelog) we no longer have the side effect of setting up the BC provider globally.
This was referenced Aug 25, 2021
kares
added a commit
that referenced
this pull request
Aug 25, 2021
With the Ruby -> Java rewrite in #178 we avoided installing the BC provider at runtime. Unfortunately to be able to decrypt some openssl keys the BC class relies on the fact that the provider is available. Otherwise reading the key leads to a `PBKDF-OpenSSL SecretKeyFactory not available`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to easily log full Java SSL exception details, we first move the SSL builder to Java.
otherwise this is ~ same as logstash-plugins/logstash-input-beats#405 :
NOTE: we also avoid installing the bouncy-castle security provider at runtime, done previously
resolves #177