Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error logging to always reveal SSL details #177

Closed
kares opened this issue Jun 15, 2021 · 0 comments · Fixed by #178
Closed

improve error logging to always reveal SSL details #177

kares opened this issue Jun 15, 2021 · 0 comments · Fixed by #178

Comments

@kares
Copy link
Contributor

kares commented Jun 15, 2021

due Netty SSLException wrapping plugin can easily fail with a wrapped error without any additional logging on the wrapped cause (Logstash currently does not log causes when handling errors at the Ruby level), sample logged exception:

[ERROR][logstash.javapipeline ][main] Pipeline error {:pipeline_id=>"main", :exception=>javax.net.ssl.SSLException: failed to initialize the server-side SSL context, :backtrace=>["io.netty.handler.ssl.JdkSslServerContext.newSSLContext(io/netty/handler/ssl/JdkSslServerContext.java:288)", "io.netty.handler.ssl.JdkSslServerContext.(io/netty/handler/ssl/JdkSslServerContext.java:247)", "io.netty.handler.ssl.SslContext.newServerContextInternal(io/netty/handler/ssl/SslContext.java:465)", "io.netty.handler.ssl.SslContextBuilder.build(io/netty/handler/ssl/SslContextBuilder.java:571)", "jdk.internal.reflect.GeneratedMethodAccessor263.invoke(jdk/internal/reflect/GeneratedMethodAccessor263)", "jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(jdk/internal/reflect/DelegatingMethodAccessorImpl.java:43)", "java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:566)", "org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:441)", "org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:305)", "usr.share.logstash.vendor.bundle.jruby.$2_dot_5_dot_0.gems.logstash_minus_input_minus_tcp_minus_6_dot_0_dot_7_minus_java.lib.logstash.inputs.tcp.compat_ssl_options.toSslContext(/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/logstash-input-tcp-6.0.7-java/lib/logstash/inputs/tcp/compat_ssl_options.rb:127)",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant