Fix driver class loading #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes to class loading intended to fix usage of :jdbc_driver_library with Java 11, introduced in `v4.3.14`, appear to have some issues (elastic/logstash#11268, logstash-plugins#355). This commit attempts to resolve those issues, and reworks the integration tests to work with docker and ensure that the :jdbc_driver_library configuration option works. This has been tested with postgresql using Java 8 and Java 11.
yaauie
approved these changes
Oct 25, 2019
robbavey
added a commit
to robbavey/logstash-filter-jdbc_streaming
that referenced
this pull request
Oct 28, 2019
Making the same fix to driver loading that was applied to the JDBC input in logstash-plugins/logstash-input-jdbc#356 This commit also reworks the test to force driver loading in the integration tests by removing the postgres gem as a dependency and doing all the database setup work in an external sql script) This fixes logstash-plugins#34 (the fix previously applied in logstash-plugins#31 did not work correctly)
elasticsearch-bot
pushed a commit
to logstash-plugins/logstash-filter-jdbc_streaming
that referenced
this pull request
Oct 29, 2019
Making the same fix to driver loading that was applied to the JDBC input in logstash-plugins/logstash-input-jdbc#356 This commit also reworks the test to force driver loading in the integration tests by removing the postgres gem as a dependency and doing all the database setup work in an external sql script) This fixes #34 (the fix previously applied in #31 did not work correctly) Fixes #35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes to class loading intended to fix usage of :jdbc_driver_library with
Java 11, introduced in
v4.3.14, appear to have some issues(elastic/logstash#11268, #355). This commit attempts
to resolve those issues, and reworks the integration tests to work with
docker and ensure that the :jdbc_driver_library configuration option works.
This has been tested with postgresql using Java 8 and Java 11.