Fix driver loading #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making the same fix to driver loading that was applied to the JDBC input in logstash-plugins/logstash-input-jdbc#356 This commit also reworks the test to force driver loading in the integration tests by removing the postgres gem as a dependency and doing all the database setup work in an external sql script) This fixes logstash-plugins#34 (the fix previously applied in logstash-plugins#31 did not work correctly)
|
LGTM |
elasticsearch-bot
pushed a commit
that referenced
this pull request
Oct 29, 2019
This was referenced Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the same fix to driver loading that was applied to the JDBC
input in logstash-plugins/logstash-input-jdbc#356
This commit also reworks the test to force driver loading in the
integration tests by removing the postgres gem as a dependency and
doing all the database setup work in an external sql script)
This fixes #34 (the fix previously applied in #31 did not work correctly)