ObjectAppendingMarker in v7.0+ has no means to access the fieldValue as its object type #719
Comments
|
Hmmm... that's weird :-( After some investigations there is no actual reasons why We could simply change that method and make it return the value of the In addition, this method should ideally be made protected as well... |
brenuart
added a commit
that referenced
this issue
Dec 20, 2021
…rming it into a String `ObjectAppendingMarker#getFieldValue()` should ideally return the value of the `fieldValue` property without transformation. This method is intended to be used by `SingleFieldAppendingMarker#tselfToString()` that already takes care of converting the value into a String. closes #719
|
@tim: is the proposed PR ok for you ? |
brenuart
added
the
status/waiting-for-feedback
|
@brenuart that sounds good to me. Appreciate the quick response! Thanks |
brenuart
removed
the
status/waiting-for-feedback
brenuart
added a commit
that referenced
this issue
Jan 5, 2022
…rming it into a String (#720) `ObjectAppendingMarker#getFieldValue()` should ideally return the value of the `fieldValue` property without transformation. This method is intended to be used by `SingleFieldAppendingMarker#tselfToString()` that already takes care of converting the value into a String. closes #719
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Have a test using AssertJ that accesses the field in ObjectAppendingMarker. It previously was called
objectand the test could access it as the correct object type. v7.0 renamed the field to befieldValueand the AssertJ reflection favours thegetFieldValuemethod over the field itself, and the getter always returns a string.Is there a way to get the fieldValue as its type rather than a string? I have a value that is a map, and having this converted to a string makes testing problematic.
The text was updated successfully, but these errors were encountered: