getFieldValue() should return the value of fieldValue without transfo…

…rming it into a String (#720) `ObjectAppendingMarker#getFieldValue()` should ideally return the value of the `fieldValue` property without transformation. This method is intended to be used by `SingleFieldAppendingMarker#tselfToString()` that already takes care of converting the value into a String. closes #719
logfellow · Jan 5, 2022 · 1e60f21 · 1e60f21
1 parent 8502ddc
commit 1e60f21
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/main/java/net/logstash/logback/marker/ObjectAppendingMarker.java b/src/main/java/net/logstash/logback/marker/ObjectAppendingMarker.java
@@ -94,8 +94,8 @@ protected void writeFieldValue(JsonGenerator generator) throws IOException {
     }
 
     @Override
-    public Object getFieldValue() {
-        return StructuredArguments.toString(fieldValue);
+    protected Object getFieldValue() {
+        return fieldValue;
     }
 
     @Override

diff --git a/src/main/java/net/logstash/logback/marker/RawJsonAppendingMarker.java b/src/main/java/net/logstash/logback/marker/RawJsonAppendingMarker.java
@@ -66,7 +66,7 @@ protected void writeFieldValue(JsonGenerator generator) throws IOException {
     }
 
     @Override
-    public Object getFieldValue() {
+    protected Object getFieldValue() {
         return rawJson;
     }
 

diff --git a/src/main/java/net/logstash/logback/marker/SingleFieldAppendingMarker.java b/src/main/java/net/logstash/logback/marker/SingleFieldAppendingMarker.java
@@ -129,7 +129,7 @@ public String toStringSelf() {
      * 
      * @return the field value
      */
-    public abstract Object getFieldValue();
+    protected abstract Object getFieldValue();
 
     @Override
     public boolean equals(Object obj) {