-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linux/ppc64le and linux/s390x builds #83
Conversation
hi @loeffel-io , could someone review/merge this PR? |
@loeffel-io : Following up on this. Could you review/merge this? |
hey folks, drone cloud is not supporting ppc64le which makes it impossible to build the ppc64le image with the current setup as you can see here: https://cloud.drone.io/loeffel-io/ls-lint/110 please let me know if you have any idea to solve this issue |
I'm not familiar with Drone Cloud. With some adjustments to the Otherwise, I can separate the nodejs and container build enablement into separate PRs; the former is my primary concern at the moment. |
@yselkowitz do you need only the binaries or a docker image? i would be fine when we just release the binaries |
ac17d26
to
6e38283
Compare
@loeffel-io let's start with that, as it's my higher priority and should be straigh-forward. I have rebased my patch to handle just that for now, and we can address the containers -- and the changes to CI that it would entail -- afterwards in a separate PR. |
thanks @yselkowitz! pretty sure that the binaries are missing for the github release https://github.com/loeffel-io/ls-lint/blob/master/.drone.yml#L48 added it myself 👍 |
fyi: v2 is on the way and comes with s390x support. ppc64le is blocked through https://github.com/loeffel-io/ls-lint/blob/master/cmd/ls_lint/target.bzl#L1. docker support is blocked through bazelbuild/rules_docker#1599 for updates: #89 |
With Feel free to try it out |
This feature is now available in the The upcoming v2.3.0 blog post: https://ls-lint.org/blog/announcements/v2.3.0.html |
No description provided.