Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux/ppc64le and linux/s390x builds #83

Closed
wants to merge 3 commits into from

Conversation

yselkowitz
Copy link

No description provided.

@levivic
Copy link

levivic commented Nov 30, 2022

hi @loeffel-io , could someone review/merge this PR?

@manojnkumar
Copy link

@loeffel-io : Following up on this. Could you review/merge this?

@loeffel-io
Copy link
Owner

hey folks,

drone cloud is not supporting ppc64le which makes it impossible to build the ppc64le image with the current setup as you can see here: https://cloud.drone.io/loeffel-io/ls-lint/110

please let me know if you have any idea to solve this issue

@yselkowitz
Copy link
Author

I'm not familiar with Drone Cloud. With some adjustments to the Dockerfile, this could be built for multiple architectures simultaneously with docker buildx, and there is (a github action) to use it, if you're willing/able to move away from Drone Cloud for this.

Otherwise, I can separate the nodejs and container build enablement into separate PRs; the former is my primary concern at the moment.

@loeffel-io
Copy link
Owner

@yselkowitz do you need only the binaries or a docker image? i would be fine when we just release the binaries

@yselkowitz
Copy link
Author

yselkowitz commented Jan 26, 2023

@loeffel-io let's start with that, as it's my higher priority and should be straigh-forward. I have rebased my patch to handle just that for now, and we can address the containers -- and the changes to CI that it would entail -- afterwards in a separate PR.

@loeffel-io
Copy link
Owner

loeffel-io commented Jan 27, 2023

thanks @yselkowitz! pretty sure that the binaries are missing for the github release https://github.com/loeffel-io/ls-lint/blob/master/.drone.yml#L48

added it myself 👍

@loeffel-io
Copy link
Owner

loeffel-io commented Jan 27, 2023

@loeffel-io
Copy link
Owner

loeffel-io commented May 17, 2023

fyi: v2 is on the way and comes with s390x support. ppc64le is blocked through https://github.com/loeffel-io/ls-lint/blob/master/cmd/ls_lint/target.bzl#L1. docker support is blocked through bazelbuild/rules_docker#1599

for updates: #89

@loeffel-io
Copy link
Owner

loeffel-io commented May 21, 2023

With v2.x s390x build are available: https://github.com/loeffel-io/ls-lint/releases/tag/v2.0.0-beta.0
ppc64le will be added as soon its available

Feel free to try it out

@loeffel-io loeffel-io closed this May 21, 2023
@loeffel-io
Copy link
Owner

ref: bazelbuild/platforms#64

@loeffel-io
Copy link
Owner

loeffel-io commented Jul 16, 2024

This feature is now available in the v2.3.0-beta.1 release.
Please test it and let me know if there are any issues ❤️

The upcoming v2.3.0 blog post: https://ls-lint.org/blog/announcements/v2.3.0.html
The docs: https://ls-lint.org/2.3/getting-started/introduction.html
The release notes: https://github.com/loeffel-io/ls-lint/releases/tag/v2.3.0-beta.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants