Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iOS): null checks in getTrueSheetView #108

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix(iOS): null checks in getTrueSheetView #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ios/TrueSheetViewManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,11 @@ class TrueSheetViewManager: RCTViewManager {

// MARK: - Private

private func getTrueSheetView(_ tag: NSNumber) -> TrueSheetView {
private func getTrueSheetView(_ tag: NSNumber) -> TrueSheetView? {
guard let uiManager = bridge?.uiManager else { return nil }
guard let viewForTag = uiManager.view(forReactTag: tag) else { return nil }
// swiftlint:disable force_cast
return bridge.uiManager.view(forReactTag: tag) as! TrueSheetView
return viewForTag as! TrueSheetView
// swiftlint:enable force_cast
}

Expand All @@ -35,12 +37,12 @@ class TrueSheetViewManager: RCTViewManager {
@objc
func present(_ tag: NSNumber, index: Int, resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) {
let trueSheetView = getTrueSheetView(tag)
trueSheetView.present(at: index, promise: Promise(resolver: resolve, rejecter: reject))
trueSheetView?.present(at: index, promise: Promise(resolver: resolve, rejecter: reject))
}

@objc
func dismiss(_ tag: NSNumber, resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) {
let trueSheetView = getTrueSheetView(tag)
trueSheetView.dismiss(promise: Promise(resolver: resolve, rejecter: reject))
trueSheetView?.dismiss(promise: Promise(resolver: resolve, rejecter: reject))
}
}