fix(iOS): null checks in getTrueSheetView #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a crash in onDismiss caused by nil values during app reloads in release builds. Both bridge and the view can be null and this is now handled in getTrueSheetView
|
@dmnkgrc is attempting to deploy a commit to the Jovanni's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Code Climate has analyzed commit af0d427 and detected 0 issues on this pull request. View more on Code Climate. |
lodev09
approved these changes
Nov 26, 2024
|
Thank you @dmnkgrc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to #35
This PR fixes a crash in onDismiss caused by nil values during app reloads in release builds. Both bridge and the view can be null and this is now handled in
getTrueSheetView. In our case it looks like there is a race condition andonDismisswas called on a non existent sheet.