-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix web options #1340
Fix web options #1340
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1340 +/- ##
==========================================
- Coverage 81.21% 81.06% -0.16%
==========================================
Files 24 24
Lines 2231 2234 +3
Branches 338 339 +1
==========================================
- Hits 1812 1811 -1
- Misses 329 333 +4
Partials 90 90
Continue to review full report at Codecov.
|
Find a free TCP port to not risk failing test because of port in use.
…ster-bind-host is specified
Looks good! I ran into an issue that was caused by MacOS (Catalina) only setting up the loopback interface for While at it, I also made a few other changes:
|
As mentioned in #1339, web_host and web_port aren't actually being used. Fixed this and added a test for it.
Still not sure about saying "*" is the default web_host when it no longer is. I changed the docstring for this anyway but idk if "" still means "all interfaces"?