Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix web options #1340

Merged
merged 9 commits into from
Apr 20, 2020
Merged

Fix web options #1340

merged 9 commits into from
Apr 20, 2020

Conversation

Trouv
Copy link
Contributor

@Trouv Trouv commented Apr 20, 2020

As mentioned in #1339, web_host and web_port aren't actually being used. Fixed this and added a test for it.

Still not sure about saying "*" is the default web_host when it no longer is. I changed the docstring for this anyway but idk if "" still means "all interfaces"?

@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #1340 into master will decrease coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1340      +/-   ##
==========================================
- Coverage   81.21%   81.06%   -0.16%     
==========================================
  Files          24       24              
  Lines        2231     2234       +3     
  Branches      338      339       +1     
==========================================
- Hits         1812     1811       -1     
- Misses        329      333       +4     
  Partials       90       90              
Impacted Files Coverage Δ
locust/argument_parser.py 75.00% <ø> (ø)
locust/env.py 95.23% <ø> (ø)
locust/main.py 20.72% <0.00%> (-0.33%) ⬇️
locust/contrib/fasthttp.py 87.56% <0.00%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84770d5...53ee05b. Read the comment docs.

@heyman
Copy link
Member

heyman commented Apr 20, 2020

Looks good!

I ran into an issue that was caused by MacOS (Catalina) only setting up the loopback interface for 127.0.0.1. I suspect you're not running MacOS, and therefore I went ahead and made a work-around for it.

While at it, I also made a few other changes:

  • The test now picks an available TCP port dynamically.
  • I changed so that the default argument for --web-host is now '*' which will be replaced with '' in main.py. The reason for this is to be consistent with how --master-bind-host is specified.

@heyman heyman merged commit a180d70 into locustio:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants