-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populate UI fields with -c, -r, --step-clients, and --step-time options #1339
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1339 +/- ##
==========================================
- Coverage 81.06% 80.78% -0.29%
==========================================
Files 24 24
Lines 2234 2243 +9
Branches 339 342 +3
==========================================
+ Hits 1811 1812 +1
- Misses 333 341 +8
Partials 90 90
Continue to review full report at Codecov.
|
I also noticed that web_port and web_host are not used in master right now. Should I go ahead and fix this in this PR or should there be a separate one? |
I'm not sure about adding four extra parameters to the
Oh, nice catch. A separate PR for that would be great! |
That's a great idea! I'll get on it |
…f passing ui_ vars around
…added a testcase in web.py
I'm +1 to merge. Maybe a mention of this feature somewhere in the documentation would be good though. |
Merged! Good job!
Added an entry to the changelog in 2d0cc67 |
Closes #1186
I had trouble thinking of test cases to write for this (I did write one), so if you have any ideas please let me know!