Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RST-11203 Copy latched messages once per split with connection header #37

Merged

Conversation

nleblanc-lr
Copy link

Eliminates a nearly identical copy of latched messages that was missing the original connection header, causing them to publish as unlatched.

@ayrton04
Copy link

ayrton04 commented Oct 1, 2024

Sorry, why would we not keep the copy, but include the header so latching works?

@nleblanc-lr
Copy link
Author

It's the same exact message being copied twice, just once without the header (so it ends up with a default unlatched header), then again with the header. This causes problems when copying the messages into another bag with rosbag python which keeps the first header it encounters for each topic and keeps reusing it, so it ends up reusing the one without the latching flag. This just gets rid of the first copy without the latching flag, but the same message is still copied in with the flag immediately after the if block I removed (same exact if block, same comments and everything, just with the original header, which I'm guessing was a merge error somewhere along the line).

@nleblanc-lr nleblanc-lr merged commit 03f6194 into locus-noetic-devel Oct 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants