Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated drupal/core patch: node_access filters out accessible nodes when node is left joined (1349080) #238

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

stephen-cox
Copy link
Member

We're using an old version of this patch and not @ekes latest version https://www.drupal.org/project/drupal/issues/1349080#comment-15334980

Fixes #237

@stephen-cox stephen-cox force-pushed the fix/2.x/237-cannot-apply-patch branch from f585d4c to e7f2a23 Compare January 10, 2024 15:31
@millnut
Copy link
Member

millnut commented Jan 11, 2024

Looks good to me @stephen-cox so I've approved.

I noticed there are deprecation errors which are introduced by 10.2 so maybe we take the same approach as localgovdrupal/localgov_paragraphs#163 (comment) so we can search for all the FIXME occurrences once Drupal 10.1 is end of life.

@stephen-cox
Copy link
Member Author

Thanks @millnut - I have created a separate issue for the deprecation failures: #240

@stephen-cox stephen-cox merged commit 59b4f7c into 2.x Jan 11, 2024
7 of 8 checks passed
@stephen-cox stephen-cox deleted the fix/2.x/237-cannot-apply-patch branch January 11, 2024 08:56
@millnut
Copy link
Member

millnut commented Jan 29, 2024

Hi @stephen-cox I've been debugging a duplicate class reference and I'm not sure if it's related to this patch https://www.drupal.org/files/issues/2023-11-27/1349080-537.patch in the PR, but when I run composer install on a fresh clone of the localgov_project repo I end up with a nested core directory and multiple of them including what new files the patch creates using new file mode i.e.

web/core
web/core/core/modules
web/core/b/core/modules

Do you see this also?

EDIT: It looks like implementing this change fixes it localgovdrupal/localgov_project#150 seems to be related to how cweagans/composer-patches calculates it's patch levels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot apply patch https://www.drupal.org/files/issues/2023-06-15/1349080-521.patch
2 participants