Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we add patchlevel directive in this project composer.json? #150

Closed
andybroomfield opened this issue Jan 18, 2024 · 4 comments · Fixed by #151
Closed

Should we add patchlevel directive in this project composer.json? #150

andybroomfield opened this issue Jan 18, 2024 · 4 comments · Fixed by #151
Labels
question Further information is requested

Comments

@andybroomfield
Copy link
Contributor

See cweagans/composer-patches#423 (comment)

  "extra": {
    "patchLevel": {
      "drupal/core": "-p2"
    }
  }

I'm running into issues applying some patches after upgrading to macOS 14.
Some repos include this already, but maybe it should be at the project level?

@andybroomfield andybroomfield added the question Further information is requested label Jan 18, 2024
@andybroomfield andybroomfield changed the title Should we add patchlevel directive in this project composer.json Should we add patchlevel directive in this project composer.json? Jan 18, 2024
@millnut
Copy link
Member

millnut commented Jan 29, 2024

I agree with @andybroomfield that this should be included by default, it also fixes the issue I'm experiencing here localgovdrupal/localgov_services#238 (comment) with patches that create new files causing nesting.

@stephen-cox
Copy link
Member

Tested this on Linux and the suggested change still works, so if this fixes things for Mac users looks fine to be made into a PR.

andybroomfield added a commit that referenced this issue Feb 8, 2024
Fix #150

Adds a patch level to project composer.json to add in development envrionments that require it.
@cweagans
Copy link

FYI, this won't be necessary for composer-patches v2. drupal/core defaults to this value.

@cweagans
Copy link

(Testing with v2 is appreciated, btw! composer require cweagans/composer-patches:"2.0.0-beta2 as 1.7" is more or less all you'd need)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants