Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the shape lib to match the upstream functions currently in PyTorch #1236

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

qedawkins
Copy link
Collaborator

Bumps the shape library:

  • The function signature for aten.arange.start_step was out of date
  • upstream_shape_functions.mean_dim -> upstream_shape_functions.sum_mean_dim

@qedawkins
Copy link
Collaborator Author

qedawkins commented Aug 17, 2022

It looks like it is failing due to the regression test which will be reverted by #1230. I'll just exclude that update for now.

@qedawkins qedawkins merged commit 85f383c into llvm:main Aug 17, 2022
@qedawkins qedawkins deleted the shape-lib-bump branch August 17, 2022 04:11
@ramiro050
Copy link
Collaborator

ramiro050 commented Aug 17, 2022

@qedawkins, thanks for fixing this! I just wanted to mention that I had already opened a PR making these fixes #1217. For bump style changes like these, it's important to check if no opened PRs already address them to avoid overlap work.

@qedawkins
Copy link
Collaborator Author

@qedawkins, thanks for fixing this! I just wanted to mention that I had already opened a PR making these fixes #1217. For bump style changes like these, it's important to check if no opened PRs already address them to avoid overlap work.

Sorry I completely missed that you already had an open PR! Someone was having issues with the shape functions and I realized there was a desync with PyTorch so after a quick approval from Sean we ended up here. Again apologies for the confusion and I'll be paying closer attention moving forward.

As an aside, I'm thinking we aren't using issue/PR labels very well and it could help to avoid these kinds of mishaps. Might be worth briefly discussing at the next developer meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants