Clean up shape functions that use sum_mean_dim
#1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramiro050
force-pushed
the
update-shape-funcs
branch
2 times, most recently
from
cbd088b
to
1855de7
Compare
|
Waiting for pytorch/pytorch#83357 to land. |
|
Hi @ramiro050, I think this PR by @qedawkins has also addressed some parts of this issue. #1236 |
I recently fixed the handling of the `dim` argument in `sum_mean_dim` (pytorch/pytorch@59fccab). Therefore, the checks that the `dim` input is `None` or `[]` are no longer needed.
ramiro050
force-pushed
the
update-shape-funcs
branch
from
1855de7
to
7d28d0a
Compare
ramiro050
changed the title
mean_dim with sum_mean_dim in shape lib + fix arangesum_mean_dim
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
Signed-off-by: Adrian Sion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently fixed the handling of the
dimargument insum_mean_dim(pytorch/pytorch@59fccab). Therefore,the checks that the
diminput isNoneor[]are no longer needed.