Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MHLO] Init MHLO slice like op patterns #1091

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

tanyokwok
Copy link
Collaborator

See RFC: #999

Co-authored-by: Bairen Yi [email protected]
Co-authored-by: Jiawei Wu [email protected]
Co-authored-by: Tianyou Guo [email protected]
Co-authored-by: Xu Yan [email protected]
Co-authored-by: Ziheng Jiang [email protected]

See RFC: llvm#999

Co-authored-by: Bairen Yi [email protected]
Co-authored-by: Jiawei Wu [email protected]
Co-authored-by: Tianyou Guo [email protected]
Co-authored-by: Xu Yan [email protected]
Co-authored-by: Ziheng Jiang [email protected]
@tanyokwok
Copy link
Collaborator Author

This is a follow-up of PR: #1090

Please review for me @silvasean @powderluv @ZihengJiang @byronyi @Yancey1989

Copy link
Collaborator

@ZihengJiang ZihengJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor suggestion, maybe we can merge those ops into ViewLikeOps or have a Uncategorized.cpp like TorchToLinalg

@silvasean
Copy link
Contributor

I will let you folks iterate on the pattern details. LGTM overall.

@tanyokwok
Copy link
Collaborator Author

One minor suggestion, maybe we can merge those ops into ViewLikeOps or have a Uncategorized.cpp like TorchToLinalg

Thanks, I will merge these codes later.

@tanyokwok tanyokwok merged commit a02dbb2 into llvm:main Jul 22, 2022
@tanyokwok tanyokwok deleted the upstream-03-init-mhlo-slice-like branch July 22, 2022 03:32
tanyokwok pushed a commit to tanyokwok/torch-mlir that referenced this pull request Jul 22, 2022
See RFC: llvm#999

Co-authored-by: Bairen Yi [email protected]
Co-authored-by: Jiawei Wu [email protected]
Co-authored-by: Tianyou Guo [email protected]
Co-authored-by: Xu Yan [email protected]
Co-authored-by: Ziheng Jiang [email protected]
gpetters94 pushed a commit to gpetters94/mlir-npcomp that referenced this pull request Jul 27, 2022
See RFC: llvm#999

Co-authored-by: Bairen Yi [email protected]
Co-authored-by: Jiawei Wu [email protected]
Co-authored-by: Tianyou Guo [email protected]
Co-authored-by: Xu Yan [email protected]
Co-authored-by: Ziheng Jiang [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants