[Clang][TableGen] Add explicit symbol visibility macros to code generated #109362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-clang Author: Thomas Fransham (fsfod) ChangesUpdate ClangAttrEmitter TableGen to add explicit symbol visibility macros to class declarations it creates. Full diff: https://github.com/llvm/llvm-project/pull/109362.diff 1 Files Affected:
diff --git a/clang/utils/TableGen/ClangAttrEmitter.cpp b/clang/utils/TableGen/ClangAttrEmitter.cpp
index 87be48c215e230..43c423eb033890 100644
--- a/clang/utils/TableGen/ClangAttrEmitter.cpp
+++ b/clang/utils/TableGen/ClangAttrEmitter.cpp
@@ -2762,7 +2762,7 @@ static void emitAttributes(const RecordKeeper &Records, raw_ostream &OS,
}
if (Header)
- OS << "class " << R.getName() << "Attr : public " << SuperName << " {\n";
+ OS << "class CLANG_ABI " << R.getName() << "Attr : public " << SuperName << " {\n";
else
OS << "\n// " << R.getName() << "Attr implementation\n\n";
@@ -3220,7 +3220,8 @@ void clang::EmitClangAttrClass(const RecordKeeper &Records, raw_ostream &OS) {
emitSourceFileHeader("Attribute classes' definitions", OS, Records);
OS << "#ifndef LLVM_CLANG_ATTR_CLASSES_INC\n";
- OS << "#define LLVM_CLANG_ATTR_CLASSES_INC\n\n";
+ OS << "#define LLVM_CLANG_ATTR_CLASSES_INC\n";
+ OS << "#include \"clang/Support/Compiler.h\"\n\n";
emitAttributes(Records, OS, true);
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Open
40 tasks
vgvassilev
force-pushed
the
exported-api/clang-tablegen
branch
from
8888f7c to
164b921
Compare
|
@AaronBallman, ping. |
|
@fsfod, can you rebase? |
…ated Update ClangAttrEmitter tablegen to add explicit symbol visibility macros to function declarations it creates. Both AnnotateFunctions and Attribute example plugins require clang::AnnotateAttr TableGen created functions to be exported from the Clang shared library.
fsfod
force-pushed
the
exported-api/clang-tablegen
branch
from
164b921 to
e395af0
Compare
PhilippRados
pushed a commit
to PhilippRados/llvm-project
that referenced
this pull request
Nov 6, 2024
…ated (llvm#109362) Update ClangAttrEmitter TableGen to add explicit symbol visibility macros to attribute class declarations it creates. Both AnnotateFunctions and Attribute example plugins require clang::AnnotateAttr TableGen created functions to be exported from the Clang shared library. This depends on macros to be added in llvm#108276
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ClangAttrEmitter TableGen to add explicit symbol visibility macros to attribute class declarations it creates.
Both AnnotateFunctions and Attribute example plugins require clang::AnnotateAttr TableGen created functions to be exported from the Clang shared library.
This depends on macros to be added in #108276