Skip to content

Commit

Permalink
[Clang][TableGen] Add explicit symbol visibility macros to code gener…
Browse files Browse the repository at this point in the history
…ated (#109362)

Update ClangAttrEmitter TableGen to add explicit symbol visibility
macros to attribute class declarations it creates.
Both AnnotateFunctions and Attribute example plugins require
clang::AnnotateAttr TableGen created functions to be exported from the
Clang shared library.
This depends on macros to be added in
#108276
  • Loading branch information
fsfod authored Nov 5, 2024
1 parent 5df3872 commit d7979c1
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions clang/utils/TableGen/ClangAttrEmitter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2727,7 +2727,8 @@ static void emitAttributes(const RecordKeeper &Records, raw_ostream &OS,
}

if (Header)
OS << "class " << R.getName() << "Attr : public " << SuperName << " {\n";
OS << "class CLANG_ABI " << R.getName() << "Attr : public " << SuperName
<< " {\n";
else
OS << "\n// " << R.getName() << "Attr implementation\n\n";

Expand Down Expand Up @@ -3185,7 +3186,8 @@ void clang::EmitClangAttrClass(const RecordKeeper &Records, raw_ostream &OS) {
emitSourceFileHeader("Attribute classes' definitions", OS, Records);

OS << "#ifndef LLVM_CLANG_ATTR_CLASSES_INC\n";
OS << "#define LLVM_CLANG_ATTR_CLASSES_INC\n\n";
OS << "#define LLVM_CLANG_ATTR_CLASSES_INC\n";
OS << "#include \"clang/Support/Compiler.h\"\n\n";

emitAttributes(Records, OS, true);

Expand Down

0 comments on commit d7979c1

Please sign in to comment.