-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport 9ff4f2d (fix for #55134 clang-tidy) to release/14.x #55717
Comments
Failed to cherry-pick: 5da7c04 https://github.com/llvm/llvm-project/actions/runs/2391590216 Please manually backport the fix and push it to your github fork. Once this is done, please add a comment like this:
|
@llvm/issue-subscribers-clang-tidy |
/cherry-pick 9ff4f2d |
@EugeneZelenko I realized I accidentally put the wrong commit hash, is there an easy way to retry the cherrypick with the correct commit hash? |
@Skylion007: just add comment with proper command. |
@EugeneZelenko I did in: #55717 (comment) |
/branch llvm/llvm-project-release-prs/issue55717 |
/pull-request llvm/llvm-project-release-prs#4 |
Ah, that worked. :) |
@Skylion007: At that time |
@AaronBallman What do you think about backporting this? 9ff4f2d |
@tstellar -- I think it's a good one to backport. |
Merged: 576e5b3 |
Initially copied wrong cherrypick here.
Backport this fix to release/14.x to fix the regression so we have a version of clang-tidy 14 that is actually usable on projects that use nolints in macros. See #55134 for more info. I tried to start the cherry pick PR myself, but as a new contributor I can't add the proper labels or milestones to this issue.
The text was updated successfully, but these errors were encountered: