Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 9ff4f2d (fix for #55134 clang-tidy) to release/14.x #55717

Closed
Skylion007 opened this issue May 26, 2022 · 13 comments · Fixed by llvm/llvm-project-release-prs#4
Closed

Comments

@Skylion007
Copy link

Skylion007 commented May 26, 2022

Initially copied wrong cherrypick here.

Backport this fix to release/14.x to fix the regression so we have a version of clang-tidy 14 that is actually usable on projects that use nolints in macros. See #55134 for more info. I tried to start the cherry pick PR myself, but as a new contributor I can't add the proper labels or milestones to this issue.

@llvmbot
Copy link
Member

llvmbot commented May 26, 2022

Failed to cherry-pick: 5da7c04

https://github.com/llvm/llvm-project/actions/runs/2391590216

Please manually backport the fix and push it to your github fork. Once this is done, please add a comment like this:

/branch <user>/<repo>/<branch>

@llvmbot
Copy link
Member

llvmbot commented May 26, 2022

@llvm/issue-subscribers-clang-tidy

@Skylion007
Copy link
Author

/cherry-pick 9ff4f2d

@Skylion007
Copy link
Author

@EugeneZelenko I realized I accidentally put the wrong commit hash, is there an easy way to retry the cherrypick with the correct commit hash?

@Skylion007 Skylion007 changed the title Backport 5da7c04 (fix for #55134 clang-tidy) to release/14.x Backport 9ff4f2d (fix for #55134 clang-tidy) to release/14.x May 26, 2022
@EugeneZelenko
Copy link
Contributor

@Skylion007: just add comment with proper command.

@Skylion007
Copy link
Author

@EugeneZelenko I did in: #55717 (comment)

@llvmbot
Copy link
Member

llvmbot commented May 26, 2022

/branch llvm/llvm-project-release-prs/issue55717

@llvmbot
Copy link
Member

llvmbot commented May 26, 2022

/pull-request llvm/llvm-project-release-prs#4

@Skylion007
Copy link
Author

Ah, that worked. :)

@EugeneZelenko
Copy link
Contributor

@Skylion007: At that time Milestone was not set.

@tstellar tstellar moved this to Needs Triage in LLVM Release Status Jun 2, 2022
@tstellar tstellar moved this from Needs Triage to Needs Review in LLVM Release Status Jun 2, 2022
@tstellar
Copy link
Collaborator

tstellar commented Jun 2, 2022

@AaronBallman What do you think about backporting this? 9ff4f2d

@AaronBallman
Copy link
Collaborator

@tstellar -- I think it's a good one to backport.

@tstellar
Copy link
Collaborator

tstellar commented Jun 3, 2022

Merged: 576e5b3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants