ThemeColorEnable -> ThemeColorMode #172
Conversation
|
That is less confusing, indeed. I'm not a fan of including that extra StringInListDrawer script unless it's really necessary. Can you not just use an enum make the dropdown? Also, I would probably change the names to "ColorChord colors" and "Custom" if it were up to me, but that's a bit of a nitpick. People may not know the CC abbreviation. |
Cool :D
IMO bordering on out of scope for AudioLink, though the same can be said for other features that have gone in in the past. Wonder how you would do that in a performant manner. Also, if you do want to add something like that, it definitely needs to work outside of VRChat too (probably just by compiling it out with some guards when not compiling for VRC). |
I agree an enum would be better. But it doesn't seem to be possible right now as I'm getting this error:
I also like those names better.
Given that theme colors are in, I think this is kind of mechanism is useful to have a centralized way of getting the theme colors.
This is not set in stone but I'm thinking of trying it this way:
This might be possible purely in shaderland, spreading sorting over multiple frames. (sorting doesn't have to be perfect) |
|
Oh, I guess enum's are only a U# 1.0 thing. Annoying. Does the script at least use a compatible license? |
|
I'll verify these changes locally when I next have time. |
Yes, the author says it's MIT licensed |
DomNomNom
changed the title
|
I added the "custom" to the input theme colors to distinguish them from the output theme colors which depend on the theme color mode. I updated the description with an updated screenshot. I think I've hit some kind of github caching bug where unless I view it in a new private browser window I still see the old image for the "after". |
|
Seems to be working great. Thanks |
* Fix broken shader includes * Add player validity check * Fix NaN propagation through slider control if duration comes back 0 * #if guarded using directives ,class declarations and code that depends vrc/udon to allow compiling without without VRCSDK and UDON * stop unity from throwing warnings * fix implicit truncation warning * recompiled UDON assets and updated prefabs * fixed truncation properly * added override keyword instead of disabling the warning * Recompiled Udon Assets * unified inconsistent line endings * Recompiled Udon Assets * Add editor define to export script * No-op incompatible code * Add render texture property to be set globally * Mode spectrum wheel model. Recompile prefabs * Copy over changelog. Move version included in releases * Add header guard to AudioLink.cginc This is a public facing API, and as such should have a header guard, so that modular shaders can include the file wherever necessary without stepping on each other's toes. As a practical example, adding AudioLink support to LTCGI usually breaks shaders when both are used in combination on one material, since `LTCGI.cginc` also includes `AudioLink.cginc`. * Fixed vertical uv flip of audio texture on Quest * Remove profiler from example scene, fixes #162 * Update instance owner use to the non-broken one. Switch from Networking.IsInstanceOwner to Networking.LocalPlayer.isInstanceOwner because the static method is known to be broken. * Revisited issue #162 Fixed a NullReferenceException that would occur if you have an empty UdonBehaviour when trying to link all sound reactive objects. * Add Demo 9 for ALPASS_THEME_COLOR * Fix Theme colors not being set. * save scene * save * Add Demo 9 to LiveScene too. * Revert to audiolink material * bracing style * add scripting define symbol * Remove some duplicated stuff and copy it over on build instead * Update changelog tentatively * Namespace mirror toggle script to prevent conflicts, recompile assets * cleanup warning * Update some audiolink note functions * revert truncation changes * fixed typos * ThemeColorEnable -> ThemeColorMode (#172) * ThemeColorsEnable -> ThemeColorMode * Use suggested labels for themeColorMode * Remove debug log * themeColorX -> customThemeColorX * update asset file with the addition of "custom" * Move some scripts, namespace editor scripts, recompile needed assets * Change fade defaults to be more responsive. (#176) * Add UTC (Unix Epoc Indexed) Timestamps (#174) * AudioLinkGetTimeOfDay * Update changelog again * Update readme * Little mistake regarding UTC time * Remove unused shader variable. (#177) * Adjust null checks for the audioSource (#180) This prevents AudioLink script from crashing when an audioSource is not present, as it might only be assigned during runtime instead of in editor. Add a warning to notify users about the missing audioSource in case it was unintentional. * fix pixelated logo on controller (#179) * Cleanup repeated uint encoding code. (#178) * Add ThemeColor controller (#181) * ThemeColorsEnable -> ThemeColorMode * Use suggested labels for themeColorMode * Remove debug log * themeColorX -> customThemeColorX * update asset file with the addition of "custom" * Add to Colors to AudioLinkController. * Add Theme color preview to bottom of controller * In progress towards ThemeColorController * Make dropdown work * yay * Fix clipping on selection markers. * brace style * sprinkle in null checks for themeColorController * use casting, not `as` * commit whatever unity did to the asset file * tweak selection indicator positions * Styling * Update readme and changelog * This is 0.2.8 * UI scooting and call things lassos * Hopefully last recompilation * Don't use material from example folder for controller Co-authored-by: Justin Aquadro <[email protected]> Co-authored-by: Float3 <[email protected]> Co-authored-by: yewnyx <[email protected]> Co-authored-by: pi <[email protected]> Co-authored-by: Shadowriver <[email protected]> Co-authored-by: Techanon <[email protected]> Co-authored-by: Nestorboy <[email protected]> Co-authored-by: DomNomNom <[email protected]> Co-authored-by: CNLohr <[email protected]> Co-authored-by: Leah <[email protected]>
I found the existing checkbox to be misleading as it turning it off still made theme colors show up but they are based off the CC colors.
This also allows more modes to be added in the future. One I'd like to add is to have the colors based off a video screen.
Before:
After:
