Revert "AA public commit" #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update platform.conf to have a successful marvell-arm64 target image.
…c-net#15265) What I did: Added change to add 'peerType' as element in NEIGH_STATE_TABLE. 'peerType' can be i-BGP vs e-BGP determined based on local and remote AS number. Why I did: This is useful to filter neighbors in SONiC as internal vs external in chassis use-case (example: telemetry) Verification: Manual Verification 127.0.0.1:6379[6]> hgetall "NEIGH_STATE_TABLE|10.0.0.5" 1) "state" 2) "Established" 3) "peerType" 4) "e-BGP" 127.0.0.1:6379[6]> hgetall "NEIGH_STATE_TABLE|2603:10e2:400::4" 1) "state" 2) "Established" 3) "peerType" 4) "i-BGP" Also sonic-mgmt test case test_bgp_fact.py is enhanced: Enhanced bgp_fact to validate NEIGH_STATE_TABLE element 'peerType' sonic-mgmt#8462
…c-net#15269) * [static_route][staticroutebfd]fix an issue on deleting a non-bfd static route Fix an issue for deleting a non-bfd static route also remove the staticroutebfd from critical_processes list and make it auto restart in the case of crash.
#### Why I did it To add new SKU Mellanox-SN4700-O8C48 with following requirements: | Port configuration | Value | | ------ |--------- | | Breakout mode for each port |**Defined in port mapping** | | Speed of the port | **Defined in Port mapping** | | Auto-negotiation enable/disable | **No setting required** | | FEC mode | **No setting required** | |Type of transceiver used | **Not needed**| Buffer configuration | Value ------ |--------- Shared headroom | **Enabled** Shared headroom pool factor | **2** Dynamic Buffer | **Disable** In static buffer scenario how many uplinks and downlinks? | **48x100G Downlinks and 8x400G uplinks** 2km cable support required? | **Yes** Switch configuration | Value ------ |--------- Warmboot enabled? | **yes** Should warmboot be added to SAI profile when enabled? | **yes** Is VxLAN source port range set? | **No** Should Vxlan source port range be added to SAI profile when set. | **No** Is Static Policy Based Hashing enabled? | **No** Port Mapping | Ports | Mode | | ------ |--------- | | 1-12 | 2x100G | | 13-20 | 1x400G | | 21-32 | 2x100G | Number of Uplinks / Downlinks: T1 topology: **48x100G Downlinks 8x400G uplinks**. Length of downlink: **40m** Length of uplink: **2000m** ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it Defined the SKU as per requirements #### How to verify it Load the SKU and verify if all links come up and traffic passes. #### A picture of a cute animal (not mandatory but encouraged)
…case (sonic-net#14952) * AclInterface and Management Interfaces are parsed on finding first valid node for it. Above logic works for multi-asic scenarios where ACL Interface and Management Interfaces are present in DPG order {Host, Asicx, Asicy} but not when DPG is in {Asicx, Asicy, Host} order.
In the PR sonic-net/sonic-utilities#2850 , for support remote access of linecards paramiko package is installed in sonic-utilities. libffi-dev needs to installed to be able to compile for armhf image Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
…-net#15286) * [202205] Update SOC properties for DLR_INIT based pfcwd recovery (sonic-net#15217) Why I did it Update soc properties for certain roles that need to use pfcwd dlr init based recovery mechanism How to verify it Updated the templates on a 7050cx3 dual tor and 7260 T1 which satisfies these conditions and validated pfcwd recovery which uses DLR_INIT based mechanism. Also validated that this mechanism is not used on 7050cx3 single tor with the updated templates Signed-off-by: Neetha John <[email protected]>
TSA/B/C scripts invoke commands that require root permissions. If the user does not have sudo permissions, the scripts today execute until the command and throw a backtrace with error at the specific command. Added a check to ensure the operations check for root permissions upfront.
…VE-2022-40302 (sonic-net#15262) Add patches from PRs FRRouting/frr#12043 FRRouting/frr#12247 #### Why I did it To fix CVEs found in FRR 8.2 #### How I did it Take commit from the FRR repo and created a patch from them
…nic-utilities submodule on master (sonic-net#15193) Dependency: sonic-net/sonic-utilities#2718 Why I did it This PR sonic-net/sonic-utilities#2718 reduce shell=True usage in utilities_common.cli.run_command() function. Work item tracking Microsoft ADO (number only): 15022050 How I did it Replace strings commands using utilities_common.cli.run_command() function to list of strings due to circular dependency, advance sonic-utilities submodule 72ca4848 (HEAD -> master, upstream/master, upstream/HEAD) Add CLI configuration options for teamd retry count feature (sonic-net/sonic-utilities#2642) 359dfc0c [Clock] Implement clock CLI (sonic-net/sonic-utilities#2793) b316fc27 Add transceiver status CLI to show output from TRANSCEIVER_STATUS table (sonic-net/sonic-utilities#2772) dc59dbd2 Replace pickle by json (sonic-net/sonic-utilities#2849) a66f41c4 [show] replace shell=True, replace xml by lxml, replace exit by sys.exit (sonic-net/sonic-utilities#2666) 57500572 [utilities_common] replace shell=True (sonic-net/sonic-utilities#2718) 6e0ee3e7 [CRM][DASH] Extend CRM utility to support DASH resources. (sonic-net/sonic-utilities#2800) b2c29b0b [config] Generate sysinfo in single asic (sonic-net/sonic-utilities#2856)
…5309) Why I did it Set build options in pipeline UI. Support setting reproducible build options to py2,py3 in release branch and none in master branch. Work item tracking Microsoft ADO (number only): 22335854 How I did it How to verify it
Why I did it FPGA driver crash was observed in Dell FPGA based platforms. How I did it Fixed FPGA crash How to verify it Load FPGA driver and check whether the kernel crashes.
When a package is referenced from the web through wget command, it downloads the package for every build. This feature caches all the packages that are being downloaded from the web, so that subsequent build always loads the cache instead of from web.
…E platform (sonic-net#15216) Why I did it Update the device data files to support 1024 LAGs for Nokia IXR7250E platform fixes Nokia-ION/ndk#15 How I did it Update the lag_id_end=1024 in chassisdb.conf file and add the trunk_group_max_members=16 in the BCM config file How to verify it check to allow to create lag ids up to 1024 with 16 port members Signed-off-by: mlok <[email protected]>
During build, lots of pip packages are getting installed through pip install command. This feature adds support for caching all the pip packages into local cache path, so that subsequent build always loads from the cache.
… the list (sonic-net#14992) * The 3 tables in state DB need to be cleaned up after SWSS restart for have consistant state.
…ave issue. (sonic-net#14686) This PR depends on sonic-net/sonic-swss#2737 merge first. **What I did** Add orchagent watchdog to monitor and alert orchagent stuck issue. **Why I did it** Currently SONiC monit system only monit orchagent process exist or not. If orchagent process stuck and stop processing, current monit can't find and report it. **How I verified it** Pass all UT. Add new UT sonic-net/sonic-mgmt#8306 to check watchdog works correctly. Manually test, after pause orchagent with 'kill -STOP <pid>', check there are warning message exist in log: Apr 28 23:36:41.504923 vlab-01 ERR swss#supervisor-proc-watchdog-listener: Process 'orchagent' is stuck in namespace 'host' (1.0 minutes). **Details if related** Heartbeat message PR: sonic-net/sonic-swss#2737 UT PR: sonic-net/sonic-mgmt#8306
Upgrade SONiC Versions
… T2 devices (sonic-net#14533) For T2 systems using packet mode, the backplane interfaces (Ethernet-BP#) and the fabric card ethernet interfaces are not visible as neighbor interfaces. In packet mode, these interfaces needs qos and buffer config as well. This fix addresses that issue and adds the backplane interfaces to the PORTS_ACTIVE list
…ave issue. (sonic-net#15429) Add watchdog mechanism to swss service and generate alert when swss have issue. **Work item tracking** Microsoft ADO (number only): 16578912 **What I did** Add orchagent watchdog to monitor and alert orchagent stuck issue. **Why I did it** Currently SONiC monit system only monit orchagent process exist or not. If orchagent process stuck and stop processing, current monit can't find and report it. **How I verified it** Pass all UT. Manually test process_monitoring/test_critical_process_monitoring.py can pass. Add new UT sonic-net/sonic-mgmt#8306 to check watchdog works correctly. Manually test, after pause orchagent with 'kill -STOP <pid>', check there are warning message exist in log: Apr 28 23:36:41.504923 vlab-01 ERR swss#supervisor-proc-watchdog-listener: Process 'orchagent' is stuck in namespace 'host' (1.0 minutes). **Details if related** Heartbeat message PR: sonic-net/sonic-swss#2737 UT PR: sonic-net/sonic-mgmt#8306
#### Why I did it The asn 0 in BGP_MONITOR is invalid by YANG definition. However, the asn 0 in BGP_MONITOR is found in many devices. It was introduced by minigraph where its value is set to 0. To unblock Config Updater test, the short term fix is to accept the asn 0 in BGP_MONITOR. We can revert this after NGS team make all the ASN change in minigraph. ##### Work item tracking - Microsoft ADO **(24186140)**: #### How I did it Change the range #### How to verify it Unit test.
Signed-off-by: Kebo Liu <[email protected]>
This reverts commit e2d729b.
liushilongbuaa
force-pushed
the
master-fake
branch
from
e2d729b
to
076e03b
Compare
liushilongbuaa
pushed a commit
that referenced
this pull request
Jan 18, 2024
…lly (sonic-net#15776) #### Why I did it src/sonic-gnmi ``` * d1467d3 - (HEAD -> 202305, origin/202305) Update makefile to support armhf (#132) (#133) (5 days ago) [ganglv] * 88ee65d - [202305] Checkout correct branch from sonic-mgmt-common and sonic-swss-common during pipeline build (#128) (5 days ago) [Sachin Holla] * 87d8eb3 - TranslClient: use PathValidator to sanitize the request paths (#112) (4 weeks ago) [Sachin Holla] ``` #### How I did it #### How to verify it #### Description for the changelog
liushilongbuaa
pushed a commit
that referenced
this pull request
Apr 23, 2024
…automatically (sonic-net#18694) #### Why I did it src/sonic-mgmt-framework ``` * 1cd7947 - (HEAD -> master, origin/master, origin/HEAD) Use pkg-config for Python linking and use OpenSSL (#133) (2 days ago) [Christian Svensson] ``` #### How I did it #### How to verify it #### Description for the changelog
liushilongbuaa
pushed a commit
that referenced
this pull request
May 8, 2024
…omatically (sonic-net#18745) #### Why I did it src/sonic-mgmt-common ``` * 5f1191e - (HEAD -> master, origin/master, origin/HEAD) Transformer Infra support for sonic yang structure deviations from flattened structure - sibling list to singleton container and nested list (#129) (33 hours ago) [amrutasali] * 8719034 - Bookworm migration for all dependency packages in azurepipeline for sonic-mgmt-common repo (#133) (3 days ago) [amrutasali] ``` #### How I did it #### How to verify it #### Description for the changelog
liushilongbuaa
pushed a commit
that referenced
this pull request
Jul 2, 2024
…utomatically (sonic-net#19373) #### Why I did it src/sonic-host-services ``` * 37c24a9 - (HEAD -> master, origin/master, origin/HEAD) Ignore sonic_platform package fileNotFoundError on non-chassis vs platforms (#133) (5 days ago) [Deepak Singhal] ``` #### How I did it #### How to verify it #### Description for the changelog
liushilongbuaa
pushed a commit
that referenced
this pull request
Aug 1, 2024
…utomatically (sonic-net#19373) #### Why I did it src/sonic-host-services ``` * 37c24a9 - (HEAD -> master, origin/master, origin/HEAD) Ignore sonic_platform package fileNotFoundError on non-chassis vs platforms (#133) (5 days ago) [Deepak Singhal] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #132