Add transceiver status CLI to show output from TRANSCEIVER_STATUS table #2772
Conversation
|
@prgeor @shyam77git @jaganbal-a @mihirpat1 could you please take a look at the PR? Moved tx_disable/tx_disabled_channel to STATUS table as requested by @mihirpat1. Raised the following additional PRs, please review as well: |
|
@longhuan-cisco can you point to the corresponding HLD for this PR in the PR description |
|
@longhuan-cisco - Are you planning to open a separate PR for non CMIS transceivers? |
|
@longhuan-cisco - Can you please help in looking into the built failure for sonic-utilities? |
Sorry for the delay on responding, was on PTO for past couple weeks. will add support for non CMIS transceivers on existing PRs (including PR of platform-common repo). And will address the comments along with updated diffs. |
longhuan-cisco
changed the title
yes, added the HLD link in the description. |
yes, addressed it. |
There was a problem hiding this comment.
- Please ensure the the CLI displays common fields for all transceivers are displayed at the top followed by CMIS specific fields followed by C_CMIS specific fields.
- Please help in attaching CLI o/p for all types of transceivers after addressing Move tx_disable/tx_disabled_channel/rx_los/tx_fault to get_transceiver_status API sonic-platform-common#359 (comment)
Addressed both. |
|
@prgeor I've addressed the comments, could you take a look plz? |
|
@longhuan-cisco can u check why Page 0h Byte 3 to 14 flags are missing For eg RX LOL, TX CDR LOL etc. |
For CMIS/C-CMIS, For 100G, |
Update sonic-utilities submodule pointer to include the following: * 5c9b2177 Fix issue: out of range sflow polling interval is accepted and stored in config_db ([sonic-net#2847](sonic-net/sonic-utilities#2847)) * 72ca4848 Add CLI configuration options for teamd retry count feature ([sonic-net#2642](sonic-net/sonic-utilities#2642)) * 359dfc0c [Clock] Implement clock CLI ([sonic-net#2793](sonic-net/sonic-utilities#2793)) * b316fc27 Add transceiver status CLI to show output from TRANSCEIVER_STATUS table ([sonic-net#2772](sonic-net/sonic-utilities#2772)) * dc59dbd2 Replace pickle by json ([sonic-net#2849](sonic-net/sonic-utilities#2849)) * a66f41c4 [show] replace shell=True, replace xml by lxml, replace exit by sys.exit ([sonic-net#2666](sonic-net/sonic-utilities#2666)) * 57500572 [utilities_common] replace shell=True ([sonic-net#2718](sonic-net/sonic-utilities#2718)) * 6e0ee3e7 [CRM][DASH] Extend CRM utility to support DASH resources. ([sonic-net#2800](sonic-net/sonic-utilities#2800)) * b2c29b0b [config] Generate sysinfo in single asic ([sonic-net#2856](sonic-net/sonic-utilities#2856)) Signed-off-by: dprital <[email protected]>
…nic-utilities submodule on master (#15193) Dependency: sonic-net/sonic-utilities#2718 Why I did it This PR sonic-net/sonic-utilities#2718 reduce shell=True usage in utilities_common.cli.run_command() function. Work item tracking Microsoft ADO (number only): 15022050 How I did it Replace strings commands using utilities_common.cli.run_command() function to list of strings due to circular dependency, advance sonic-utilities submodule 72ca4848 (HEAD -> master, upstream/master, upstream/HEAD) Add CLI configuration options for teamd retry count feature (sonic-net/sonic-utilities#2642) 359dfc0c [Clock] Implement clock CLI (sonic-net/sonic-utilities#2793) b316fc27 Add transceiver status CLI to show output from TRANSCEIVER_STATUS table (sonic-net/sonic-utilities#2772) dc59dbd2 Replace pickle by json (sonic-net/sonic-utilities#2849) a66f41c4 [show] replace shell=True, replace xml by lxml, replace exit by sys.exit (sonic-net/sonic-utilities#2666) 57500572 [utilities_common] replace shell=True (sonic-net/sonic-utilities#2718) 6e0ee3e7 [CRM][DASH] Extend CRM utility to support DASH resources. (sonic-net/sonic-utilities#2800) b2c29b0b [config] Generate sysinfo in single asic (sonic-net/sonic-utilities#2856)
|
@yxieca @StormLiangMS - Can you please help with cherry-pick for this to 202205 and 202211 |
|
@prgeor this is already in 202305. |
…le (sonic-net#2772) * Add transceiver status CLI to display TRANSCEIVER_STATUS table for CMIS/C-CMIS * Fix typo in command-ref * Add tx_disable * Update tx_disabled_channel's discription * Remove redundant code * addressed comments * Fix typo for tx power low warning * Separate CMIS and CCMIS status map * code cleanup * Unify display format and update display order * Fix after merge from master
…nic-utilities submodule on master (sonic-net#15193) Dependency: sonic-net/sonic-utilities#2718 Why I did it This PR sonic-net/sonic-utilities#2718 reduce shell=True usage in utilities_common.cli.run_command() function. Work item tracking Microsoft ADO (number only): 15022050 How I did it Replace strings commands using utilities_common.cli.run_command() function to list of strings due to circular dependency, advance sonic-utilities submodule 72ca4848 (HEAD -> master, upstream/master, upstream/HEAD) Add CLI configuration options for teamd retry count feature (sonic-net/sonic-utilities#2642) 359dfc0c [Clock] Implement clock CLI (sonic-net/sonic-utilities#2793) b316fc27 Add transceiver status CLI to show output from TRANSCEIVER_STATUS table (sonic-net/sonic-utilities#2772) dc59dbd2 Replace pickle by json (sonic-net/sonic-utilities#2849) a66f41c4 [show] replace shell=True, replace xml by lxml, replace exit by sys.exit (sonic-net/sonic-utilities#2666) 57500572 [utilities_common] replace shell=True (sonic-net/sonic-utilities#2718) 6e0ee3e7 [CRM][DASH] Extend CRM utility to support DASH resources. (sonic-net/sonic-utilities#2800) b2c29b0b [config] Generate sysinfo in single asic (sonic-net/sonic-utilities#2856)
What I did
Add transceiver status CLI to show output from TRANSCEIVER_STATUS table
(info for TRANSCEIVER_STATUS table and CLI can be found in hld: https://github.com/sonic-net/SONiC/blob/master/doc/platform_api/CMIS_and_C-CMIS_support_for_ZR.md)
How I did it
How to verify it
verified on 400G regular and ZR optics (CMIS/C-CMIS) and 100G optics, that the status output was displayed properly for single interface as well as for all interfaces, and
not applicablemessage was shown up properly for optics whose status table is missing.Previous command output (if the output of a command-line utility has changed)
N/A
New command output (if the output of a command-line utility has changed)
For non-CMIS/C-CMIS optics (e.g. 100G):
For CMIS optics (non-ZR 400G):
For C-CMIS optics (ZR):