Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cargo-chef #660

Merged
merged 6 commits into from
Jun 27, 2022
Merged

Remove cargo-chef #660

merged 6 commits into from
Jun 27, 2022

Conversation

Kailai-Wang
Copy link
Collaborator

@Kailai-Wang Kailai-Wang commented Jun 27, 2022

resolves #659

This PR:

  • removes cargo-chef
  • removes local buildx cache
  • set PROFILE as docker arg

If we found better ways for caching within docker, we can adjust it later (or even add back cargo-chef if it's improved)

@Kailai-Wang Kailai-Wang requested a review from a team June 27, 2022 11:20
@Kailai-Wang Kailai-Wang self-assigned this Jun 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022

Codecov Report

Merging #660 (946a11c) into dev (7298a1f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #660   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files          12       12           
  Lines        1666     1666           
=======================================
  Hits         1598     1598           
  Misses         68       68           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7298a1f...946a11c. Read the comment docs.

@BillyWooo BillyWooo assigned BillyWooo and unassigned BillyWooo Jun 27, 2022
@BillyWooo BillyWooo self-requested a review June 27, 2022 18:09
Copy link
Collaborator

@BillyWooo BillyWooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me.

@Kailai-Wang Kailai-Wang merged commit 61c2cb2 into dev Jun 27, 2022
@Kailai-Wang Kailai-Wang deleted the 659-remove-cargo-chef branch June 27, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove cargo-chef and buildx cache
3 participants