Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cargo-chef and buildx cache #659

Closed
Kailai-Wang opened this issue Jun 27, 2022 · 0 comments · Fixed by #660
Closed

Remove cargo-chef and buildx cache #659

Kailai-Wang opened this issue Jun 27, 2022 · 0 comments · Fixed by #660
Assignees
Labels
D1-feature A new feature, a piece of functionality that needs to be developed I4-urgent should be completed within 4-6 hours

Comments

@Kailai-Wang
Copy link
Collaborator

Kailai-Wang commented Jun 27, 2022

Context

After several's months' run the cargo-chef and buildx cache (from #409), it doesn't seem to be very effective - our CI-runner needs ~20 min anyway to run a docker build with release profile.

Additionally, cargo-chef seems to remove the inherits from the production profile which caused problems:

error: profile `production` is missing an `inherits` directive (`inherits` is required for all profiles except `dev` or `release`)

Task

Remove use of cargo-chef

Acceptance criteria

cargo-chef is removed and CI doesn't break

If we found better ways for caching within docker, we can adjust it later (or even add back cargo-chef if it's improved)


✔️ Please set appropriate labels and assignees if applicable.

@Kailai-Wang Kailai-Wang added I4-urgent should be completed within 4-6 hours D1-feature A new feature, a piece of functionality that needs to be developed labels Jun 27, 2022
@Kailai-Wang Kailai-Wang self-assigned this Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D1-feature A new feature, a piece of functionality that needs to be developed I4-urgent should be completed within 4-6 hours
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant