Kill Firecracker if SendCtrlAltDel failed #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firecracker on arm machines does not support the SendCtrlAltDel action
and luckily it throws back an error instead of silently does nothing.
Why lucky? That way if the SendCtrlAltDel failed, we can rety to kill it
with a graceful SIGINT signal and if it did not work, we can throw back
an error and say "we did what we could".
Error message from Firecracker:
{"fault_message":"SendCtrlAltDel does not supported on aarch64."}
Fixes liquidmetal-dev#152
Callisto13
reviewed
Oct 29, 2021
Callisto13
reviewed
Oct 29, 2021
Comment on lines
+167
to
+176
| if errors.Is(err, &url.Error{}) { | ||
| logger.Info("microvm is not running") | ||
| } else if pid, pidErr := vmState.PID(); pidErr != nil { | ||
| logger.Infof("sending SIGINT to %d", pid) | ||
|
|
||
| if sigErr := process.SendSignal(pid, os.Interrupt); sigErr != nil { | ||
| return fmt.Errorf("failed to create halt action: %w", err) | ||
| } | ||
| } else { | ||
| return fmt.Errorf("failed to create halt action: %w", err) |
There was a problem hiding this comment.
i am slightly worried that this section could become a bit unwieldy the more error/check variations we add... but happy to leave it until we actually see it happening
There was a problem hiding this comment.
I think in both cases the result is the same, failed delete and the wrapped error will tell why.
Codecov Report
@@ Coverage Diff @@
## main #177 +/- ##
==========================================
+ Coverage 47.00% 54.16% +7.16%
==========================================
Files 45 45
Lines 1951 1968 +17
==========================================
+ Hits 917 1066 +149
+ Misses 930 795 -135
- Partials 104 107 +3
Continue to review full report at Codecov.
|
Callisto13
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Firecracker on arm machines does not support the SendCtrlAltDel action
and luckily it throws back an error instead of silently does nothing.
Why lucky? That way if the SendCtrlAltDel failed, we can rety to kill it
with a graceful SIGINT signal and if it did not work, we can throw back
an error and say "we did what we could".
Error message from Firecracker:
Which issue(s) this PR fixes:
Fixes #152
Checklist: