Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill firecracker on shutdown if CtrlAltDel action did not work (ARM) #152

Closed
yitsushi opened this issue Oct 20, 2021 · 1 comment · Fixed by #177
Closed

Kill firecracker on shutdown if CtrlAltDel action did not work (ARM) #152

yitsushi opened this issue Oct 20, 2021 · 1 comment · Fixed by #177
Assignees
@yitsushi
Labels
area/firecracker Indicates an issue or PR related to Firecracker kind/feature New feature or request priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@yitsushi
Copy link
Contributor

yitsushi commented Oct 20, 2021 •
edited
Loading

Known issues and Limitations

The SendCtrlAltDel API request is not supported for aarch64 enabled microVMs.

Source: https://github.com/firecracker-microvm/firecracker#known-issues-and-limitations

Read more:
https://github.com/firecracker-microvm/firecracker/blob/main/docs/api_requests/actions.md#intel-and-amd-only-sendctrlaltdel

Suggested approach:

  1. Send CtrlAltDel action
  2. Wait maybe 1 second
  3. If it's still running, kill the process
@yitsushi yitsushi added area/firecracker Indicates an issue or PR related to Firecracker kind/feature New feature or request labels Oct 20, 2021
@richardcase
Copy link
Member

And some discussions around this:
firecracker-microvm/firecracker#1370
firecracker-microvm/firecracker#1534

@richardcase richardcase added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Oct 20, 2021
@yitsushi yitsushi self-assigned this Oct 27, 2021
yitsushi added a commit to yitsushi/flintlock that referenced this issue Oct 27, 2021
@yitsushi
Kill Firecracker if SendCtrlAltDel failed
01d76d8 
Firecracker on arm machines does not support the SendCtrlAltDel action
and luckily it throws back an error instead of silently does nothing.

Why lucky? That way if the SendCtrlAltDel failed, we can rety to kill it
with a graceful SIGINT signal and if it did not work, we can throw back
an error and say "we did what we could".

Error message from Firecracker:

    {"fault_message":"SendCtrlAltDel does not supported on aarch64."}

Fixes liquidmetal-dev#152
@yitsushi yitsushi mentioned this issue Oct 27, 2021
Merged
4 tasks
yitsushi added a commit that referenced this issue Oct 29, 2021
@yitsushi
Kill Firecracker if SendCtrlAltDel failed (#177)
5c4d0d5 
* Kill Firecracker if SendCtrlAltDel failed

Firecracker on arm machines does not support the SendCtrlAltDel action
and luckily it throws back an error instead of silently does nothing.

Why lucky? That way if the SendCtrlAltDel failed, we can rety to kill it
with a graceful SIGINT signal and if it did not work, we can throw back
an error and say "we did what we could".

Error message from Firecracker:

    {"fault_message":"SendCtrlAltDel does not supported on aarch64."}

Fixes #152

* merge lines for error check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yitsushi yitsushi

Labels
area/firecracker Indicates an issue or PR related to Firecracker kind/feature New feature or request priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Kill Firecracker if SendCtrlAltDel failed yitsushi/flintlock
2 participants
@yitsushi @richardcase