feat: deploy containers to ecr TDE-689 #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MDavidson17
force-pushed
the
feat/deploy-containers-to-ecr
branch
from
41e6a96
to
2ebdf0c
Compare
paulfouquet
reviewed
Mar 23, 2023
paulfouquet
reviewed
Mar 24, 2023
amfage
previously approved these changes
Mar 24, 2023
paulfouquet
approved these changes
Mar 24, 2023
Merged
blacha
pushed a commit
to linz/argo-tasks
that referenced
this pull request
Apr 2, 2023
https://github.com/aws-actions/amazon-ecr-login#examples-of-usage linz/topo-imagery#408 linz/topo-imagery#415 --------- Co-authored-by: paulfouquet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the guidelines here: https://github.com/aws-actions/amazon-ecr-login#building-and-pushing-an-image
Considerations:
Cost: https://aws.amazon.com/ecr/pricing/
In particular - storage: $0.10 per GB /Month
Lifecylce: https://docs.aws.amazon.com/AmazonECR/latest/userguide/LifecyclePolicies.html
Screenshots from test deployments:
Branch:
test/aws-configureFirst Deployment:
Second Deployment (after update to topo-imagery):