chore: remove comments

linz · Mar 22, 2023 · 41e6a96 · 41e6a96
1 parent 3cdfa8c
commit 41e6a96
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 3 deletions.
diff --git a/.github/workflows/containers.yml b/.github/workflows/containers.yml
@@ -50,13 +50,11 @@ jobs:
           REPOSITORY: eks
           IMAGE_TAG: ${{ github.sha }}
         run: |
-          # Q: do we need to reset this or will it be remembered from above?
           GIT_VERSION=$(git describe --tags --always --match 'v*')
           docker pull ghcr.io/linz/topo-imagery:${GIT_VERSION}
 
           docker tag ghcr.io/linz/topo-imagery:${GIT_VERSION} ${{ secrets.AWS_ACCOUNT_ID_PROD }}.dkr.ecr.ap-southeast-2.amazonaws.com/eks:topo-imagery
           docker tag ghcr.io/linz/topo-imagery:${GIT_VERSION} ${{ secrets.AWS_ACCOUNT_ID_PROD }}.dkr.ecr.ap-southeast-2.amazonaws.com/eks:topo-imagery-${GIT_VERSION}
 
           docker push ${{ secrets.AWS_ACCOUNT_ID_PROD }}.dkr.ecr.ap-southeast-2.amazonaws.com/eks:topo-imagery
-          # Q: do we want to push all containers? What is the cost and should we set up a mechanism to delete older versions?
           docker push ${{ secrets.AWS_ACCOUNT_ID_PROD }}.dkr.ecr.ap-southeast-2.amazonaws.com/eks:topo-imagery-${GIT_VERSION}
diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml
@@ -64,7 +64,6 @@ jobs:
           REPOSITORY: eks
           IMAGE_TAG: ${{ github.sha }}
         run: |
-          # Q: do we need to reset this or will it be remembered from above?
           GIT_VERSION=$(git describe --tags --always --match 'v*')
           GIT_VERSION_MAJOR=$(echo $GIT_VERSION | cut -d. -f1)
           GIT_VERSION_MAJOR_MINOR=$(echo $GIT_VERSION | cut -d. -f1,2)