Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-8452, M3-8603] - Add Resource Links & Fix Test Flake #11047

Merged
merged 3 commits into from
Oct 7, 2024
Merged

upcoming: [M3-8452, M3-8603] - Add Resource Links & Fix Test Flake #11047

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29dd099
upcoming: [M3-8452] - Add Resource Links & Fix Test Flake
jaalah Oct 4, 2024
e4d667f
Review updates @mjac0bs
jaalah Oct 7, 2024
0b566a8
Update pr-11047-upcoming-features-1728307120334.md
jaalah-akamai Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/manager/src/features/ObjectStorage/BucketDetail/AccessSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,11 @@ export const AccessSelect = React.memo((props: Props) => {
})}
>
CORS (Cross Origin Sharing) is not available for endpoint types E2
and E3. <Link to="#">Learn more</Link>.
and E3.{' '}
<Link to="https://techdocs.akamai.com/cloud-computing/docs/define-access-and-permissions-using-acls-access-control-lists">
Learn more
</Link>
.
</Typography>
</Notice>
)}
Expand Down
6 changes: 5 additions & 1 deletion packages/manager/src/features/ObjectStorage/BucketLanding/BucketRateLimitTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,11 @@ export const BucketRateLimitTable = ({
) : (
'This endpoint type supports up to 750 Requests Per Second (RPS). '
)}
Understand <Link to="#">bucket rate limits</Link>.
Understand{' '}
<Link to="https://techdocs.akamai.com/cloud-computing/docs/create-and-manage-buckets">
mjac0bs marked this conversation as resolved.
Show resolved Hide resolved
bucket rate limits
</Link>
.
</Typography>

{isGen2EndpointType && (
Expand Down
2 changes: 1 addition & 1 deletion packages/manager/src/features/ObjectStorage/BucketLanding/CreateBucketDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export const CreateBucketDrawer = (props: Props) => {
};

const clusterRegion = watchCluster
? regions?.find((region) => watchCluster.includes(region.id))
? regions?.find((region) => watchCluster === region.id)
jaalah-akamai marked this conversation as resolved.
Show resolved Hide resolved
: undefined;

const { showGDPRCheckbox } = getGDPRDetails({
Expand Down
7 changes: 5 additions & 2 deletions packages/manager/src/features/ObjectStorage/BucketLanding/OMC_CreateBucketDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ export const OMC_CreateBucketDrawer = (props: Props) => {
};

const selectedRegion = watchRegion
? regions?.find((region) => watchRegion.includes(region.id))
? regions?.find((region) => watchRegion === region.id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Confirming that this fixes the test flake with bucket-create-gen2.spec.ts when selecting the mock us-10 region.

: undefined;

const filteredEndpoints = endpoints?.filter(
Expand Down Expand Up @@ -341,7 +341,10 @@ export const OMC_CreateBucketDrawer = (props: Props) => {
<Typography component="span">
Endpoint types impact the performance, capacity, and
rate limits for your bucket. Understand{' '}
<Link to="#">endpoint types</Link>.
<Link to="https://techdocs.akamai.com/cloud-computing/docs/object-storage">
endpoint types
</Link>
.
</Typography>
),
helperTextPosition: 'top',
Expand Down