upcoming: [M3-8452, M3-8603] - Add Resource Links & Fix Test Flake #11047
Conversation
jaalah-akamai
requested review from
mjac0bs,
bnussman-akamai and
AzureLatte
and removed request for
a team
|
Coverage Report: ✅ |
There was a problem hiding this comment.
Can we add two changesets? One to note the fixed tests, and another in upcoming features for the docs links.
Confirmed the intended tests pass consistently locally and the fix makes sense. But, seeing a consistent failure with enable-object-storage.spec.ts, which is looking for the pricing helper text in the create drawer but it does not display. This also seems to be the case in the UI locally if the OMC feature flag is toggled off. (The test mocks the feature flag as false.) Not sure what's happening there, as the OveragePricing component is present in both OMC and non-OMC create drawers. Has this been failing recently and is captured in another ticket? Seems unrelated to this PR.
Also confirmed the docs links redirect to real pages.
packages/manager/src/features/ObjectStorage/BucketLanding/BucketRateLimitTable.tsx
Show resolved
Hide resolved
packages/manager/src/features/ObjectStorage/BucketLanding/CreateBucketDrawer.tsx
Outdated
Show resolved
Hide resolved
| @@ -179,7 +179,7 @@ export const OMC_CreateBucketDrawer = (props: Props) => { | |||
| }; | |||
|
|
|||
| const selectedRegion = watchRegion | |||
| ? regions?.find((region) => watchRegion.includes(region.id)) | |||
| ? regions?.find((region) => watchRegion === region.id) | |||
There was a problem hiding this comment.
Nice! Confirming that this fixes the test flake with bucket-create-gen2.spec.ts when selecting the mock us-10 region.
jdamore-linode
changed the title
jaalah-akamai
added
Add'tl Approval Needed
mjac0bs
added
Approved
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 25m 11s |
| Commit |
|
| Committer | Jaalah Ramos |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
414
|
| View all changes introduced in this branch ↗︎ | |
…inode#11047) * upcoming: [M3-8452] - Add Resource Links & Fix Test Flake * Review updates @mjac0bs * Update pr-11047-upcoming-features-1728307120334.md --------- Co-authored-by: Jaalah Ramos <[email protected]>
Description 📝
Update OBJ Gen2 resource links and fix issue causing test flake.
Changes 🔄
.includeswas causing test flake because the substring could match several options. IE: If looking forus-10, it may returnus-1or evenus-100. SeeM3-8603Target release date 🗓️
N/A
Screenshots
How to test 🧪
Verification steps
Ensure tests pass and links work!
As an Author I have considered 🤔
Check all that apply