Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): ensure that the controller sets rate limit status #13377

Merged
merged 3 commits into from
Nov 22, 2024
Merged

fix(test): ensure that the controller sets rate limit status #13377

merged 3 commits into from
Nov 22, 2024

Commits on Nov 22, 2024

  1. fix(test): ensure that the controller sets rate limit status 

    The http_local_rate_limit_policy test creates a resource with a status already
hidrated, but status setting is a job of the controller.

This change updates the test to create a resource without a status and then to
wait for the status to be set properly.

This will hopefully help us to avoid race conditions in this test whereby the
API lookup can occur before the controller observes the resource creation.
    @olix0r
    olix0r committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    daa9361 View commit details
    Browse the repository at this point in the history

  2. clippy

    @olix0r
    olix0r committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    7ac0d74 View commit details
    Browse the repository at this point in the history

  3. touchup

    @olix0r
    olix0r committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    63ad8ad View commit details
    Browse the repository at this point in the history