fix(test): ensure that the controller sets rate limit status #13377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The http_local_rate_limit_policy test creates a resource with a status already hidrated, but status setting is a job of the controller. This change updates the test to create a resource without a status and then to wait for the status to be set properly. This will hopefully help us to avoid race conditions in this test whereby the API lookup can occur before the controller observes the resource creation.
alpeb
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The http_local_rate_limit_policy test creates a resource with a status already hydrated, but status setting is a job of the controller.
This change updates the test to create a resource without a status and then to wait for the status to be set properly.
This will hopefully help us to avoid race conditions in this test whereby the API lookup can occur before the controller observes the resource creation.