-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix 13327] ignore HTTPRoute .status.parents re-ordering #13328
Conversation
Signed-off-by: Derek Brown <[email protected]>
Do we need the same treatment for the conditions comparison? linkerd2/policy-controller/k8s/status/src/index.rs Lines 1538 to 1553 in 8265134
|
AFAIK, K8s preserves the order of lists in the All that said, it can't hurt (besides a little added complexity) to do order invariant comparison for conditions as well. Up to you- happy to extend to cover conditions as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Commit Message: